Order Delivery Date Support Thread

[plantman]

Sorry, I thought of that just now. They are the plain text emails. A lot of our customers are schools and html emails don't go through some of the systems well.

[mc12345678]

Sorry, I thought of that just now. They are the plain text emails. A lot of our customers are schools and html emails don't go through some of the systems well.

Your includes/classes/orders.php file should have a notifier at or around line 1018:

$this->notify('NOTIFY_ORDER_EMAIL_BEFORE_PRODUCTS', array(), $email_order, $html_msg);

Also the new code located in includes/classes/observers/auto.order_delivery_date_observer.php within the function updateNotifyOrderEmailBeforeProducts should have a line:

$email_order .= EMAIL_TEXT_DELIVERY_DATE . ' '  . zen_db_output($callingClass->info['order_delivery_date']) . "\n\n";

that appends the delivery date to just after the customer provided comments block...

That the data is available in the admin does indicate that at least it was stored with the order and confirms that it is locatable in the database and therefore should be present to be used in the above code.


Ohhhh... That all is fine and dandy, but the identification of using the above function is missing from the observer class:

Add the following at line 33 (moving existing line 33 down one) of includes/classes/observers/auto.order_delivery_date_observer.php:

    $attachNotifier[] = 'NOTIFY_ORDER_EMAIL_BEFORE_PRODUCTS';

Change shown and incorporated in master branch: https://github.com/mc12345678/order-delivery-date/commit/53e749993e8c6a02780a28ed7dc04477826735df#diff-dbecab78edebe73f70eecd555e1b74cd

[plantman]

All of that appears to be there but but that doesn't seem to be doing the job.

[mc12345678]

All of that appears to be there but but that doesn't seem to be doing the job.

Until about 15 minutes ago, the $attachNotifier identified above was not present in the file system:

The line listed in red below has been newly added to the file download, needs to be added to your installation, and would be a reason that the email would not include the order delivery date information (in either html or plain text).

This is from/to be in: includes/classes/observers/auto.order_delivery_date_observer.php

  function __construct() {
    $attachNotifier = array();
    $attachNotifier[] = 'NOTIFY_ORDER_AFTER_QUERY';
    $attachNotifier[] = 'NOTIFY_ORDER_CART_FINISHED';
    $attachNotifier[] = 'NOTIFY_ORDER_DURING_CREATE_ADDED_ORDER_HEADER';
    $attachNotifier[] = 'NOTIFY_ORDER_EMAIL_BEFORE_PRODUCTS';
    $attachNotifier[] = 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING';
    $attachNotifier[] = 'ORDER_QUERY_ADMIN_COMPLETE';
    $this->attach($this, $attachNotifier);
  }

If it was added while still logged in from the previous test, may need to log out and log back in/clear cache/sessions for the information to get "refreshed". Otherwise, you may have read the message before it was modified and only now have seen the modification that fixes the issue. :)

[plantman]

The added code took care of it. You are awesome. Thanks

[mc12345678]

The added code took care of it. You are awesome. Thanks

Keep the feedback coming in whatever it is you test, try, or use... Everyone that has written something or added their touch can only really know what is and is not working by the feedback from the users. Mind you, it's most helpful to everyone if at least a little self research is done, but everyone makes mistakes. I could have deleted that entire "logic", but if nothing else you can see the process of elimination that I used... :) Had to go back to the basics again. :)

Thank you for confirming it fixed the issue. Now to write some more instruction on how to manage a transition from an older version to this one and maybe how it can be operated in ZC 1.5.3/1.5.4 (was just looking at the notifiers to see if it was possible without significant change to the ZC software).

I have also seen that there might be a remote possibility of capturing a time option as requested a few pages back which means likely will want to introduce an auto-installer to make the overall installation and support easier...

[mc12345678]

Posted version 2.5.2 of the plugin to the ZC software moderators.

What changed v2.5.2:

- Removed modifications from core files and used the notifier/observer system instead for ZC 1.5.5. Specifically the autoloader system.
- Replaced the mootools javascript with software that works with ZC 1.5.5.
- Removed changes from template files that did not get incorporated into ZC 1.5.5.
- Added text to identify that the delivery date is optional/required.

Once accepted it will be available for download from the ZC forum from here.

[mc12345678]

Posted version 2.5.2 of the plugin to the ZC software moderators.



Once accepted it will be available for download from the ZC forum from here.

Version 2.5.2 has been reviewed and posted and is available from this zen-cart link: