PHP coding.

[Xam]

Hi !

Anyone to gimme a hand ?

I'm not used to PHP. Much better at Coldfusion.
What would be the PHP code for the following ?

if "X" ≥ 1 and "X" < 3
set variable "D2"

if "X" ≥ 3 and "X" < 5
set variable "D3"

if "X" ≥ 5 and "X" < 11
set variable "D4"

if "X" ≥ 11
set variable "C1"

if "X" is undefined
set variable "C1"

[kuroi]

What do you want to set these variables to?

What happens is X < 1?

Is X of type integer or floating point (or something else)?

[Xam]

X would be the number of product in my cart

if X < 1 then X should be undefined

I thought about something like that :

<?
$ X = $_post ['X_from_a_form']

if ( $ X >= 1 && $ X < 3 )
{
$ myvar = 'D2' ;
}

elseif ( $ X >= 3 && $ X < 5 )
{
$ myvar = 'D3' ;
}

elseif ( $ X >=5 && $ X < 11 )
{
$ myvar = 'D4' ;
}

elseif ( $ X >= 11 )
{
$ myvar = 'C1' ;
}

else ( $ X < 1 )
{
$ myvar = 'C1';
}

?>

Is it good ?

[kuroi]

This would be more elegant and more robust

<?php
if (!isset($_POST['X_from_a_form']) || (int)$_POST['X_from_a_form'] < 1 || $_POST['X_from_a_form'] <= 11) {
  $myvar = 'C1';
} elseif((int)$_POST['X_from_a_form'] < 3) {
  $myvar = 'D2';
} elseif((int)$_POST['X_from_a_form'] < 5) {
  $myvar = 'D3'; 
} else {
  $myvar = 'D4';
}
?>

Depending upon the wider context a switch statement might be more appropriate, though I doubt it in this case

<?php
if (isset($_POST['X_from_a_form'])) {
  switch ((int)$_POST['X_from_a_form']) {
    case 1:
    case 2: $myvar = 'D2'; break;
    case 3:
    case 4: $myvar = 'D3'; break;
    case 5:
    case 6:
    case 7:
    case 8:
    case 9:
    case 10: $myvar = 'D4'; break;
    default: $myvar = 'C1';
  }
} else {
  $myvar = 'C1';
}
?>

[Xam]

thank you kuroi !!

I'll try these.

[kuroi]

Just spotted a missing (int) in the last condition of the first line in the first example. It's unlikely to be a problem, but hey, why take the risk.