Attribute Pricing Changes with Sale Price-WRONG!

**makenoiz** · 22 Dec 2009, 05:57 PM

There is nothing there that pertains to my problem. (?) Unless I missed it. I looked through all the pages of bugs.....

**Ajeh** · 22 Dec 2009, 06:37 PM

I'd check anything to do with master_categories_id which is used on pricing ...

I cannot reproduce the problem on my current v1.3.8 with the fixes and would have to think this is related to your installation and add ons etc.

Is this an upgrade or clean v1.3.8 that you are using?

**Ajeh** · 22 Dec 2009, 06:38 PM

Also check your SaleMaker settings ... usually you need to be sure that you are using:

Specials Condition: Apply SaleDeduction to Specials Price - Otherwise Apply to Price

**makenoiz** · 3 Jan 2010, 03:57 AM

Sorry to keep pestering you about this. Should this work with Specials as well? I really dont want to put the entire master category on sale.

I have the item priced at 0 and the attributes are priced individually. When using SaleMaker I get this (prices at 0 on display page and BUT correct - deducted amount in the cart -yea!):

http://www.mendweb.com/images/salemaker.gif

Just need to display the correct deducted amounts under the attributes and show the correct starting amount.

BUT Id rather user SPECIALS so that I dont have to put an entire Master Cat on sale:
When using Specials, I get no visible changes on the product display page at all and the price is not changed when added to cart.

So - it looks like Im closer with SaleMaker, just need to display the correct prices. I want to use Specials though. To be honest, the very best would be to be able to discount on an attribute level but I have searched and dont see anything.

Any other ideas you may have or anything that you think I should check would be really appreciated.

Thanks for listening to my rambling.

Thank you in advance.

**Ajeh** · 3 Jan 2010, 04:29 AM

Have you an URL that we could perhaps peek at on this?

And could you tell us what you have set the Prices as on the Attributes and what you think you should be seeing?

Also, on the Attributes what settings are you using for:
Apply Discounts Used
by Product Special/Sale:

Include in Base Price
When Priced by Attributes

For Sale Maker, what settings are you using?

**makenoiz** · 5 Jan 2010, 08:02 AM

Well Ajeh, in the interest of time, I have just coded a way to make it happen. I usually try to work with the existing code to limit breakage later but ... not this time. I appreciate your efforts.

First off I discovered that to boolean for priced by attribute had not bee set correctly when the product was added to the DB (my error - I had tweaked the info collect php). That solved the issue of the $0.00 attribute price. Then to get the attribute pricing to show up like this:

http://www.mendweb.com/images/attributesale.gif

I added some code, a flag and some more code to attributes.php . My atttributes.php is highly modified so please be careful when trying to use this code. This is only for reference and cannot be directly plugged into your files!!

But essentially here is the logic.

1)Add a flag variable and set to false at the top of file. MIne is on line 19 $onSaleFlag = FALSE;
2) Around line 157 when showing sale discount I changed

Code:

if ($products_options->fields['options_values_price'] != '0' and ($products_options->fields['product_attribute_is_free'] != '1' and $product_info->fields['product_is_free'] != '1')) {
                      // show sale maker discount if a percentage
                      $products_options_display_price= ATTRIBUTES_PRICE_DELIMITER_PREFIX . $products_options->fields['price_prefix'] .
                      $currencies->display_price($new_attributes_price, zen_get_tax_rate($product_info->fields['products_tax_class_id'])) . ATTRIBUTES_PRICE_DELIMITER_SUFFIX;

to be

Code:

if ($products_options->fields['options_values_price'] != '0' and ($products_options->fields['product_attribute_is_free'] != '1' and $product_info->fields['product_is_free'] != '1')) {
                      // show sale maker discount if a percentage
                      $products_options_display_price= ' <!--attributes '.__LINE__.' --><br/><span class="productSalePrice">' . PRODUCT_PRICE_SALE . $products_options->fields['price_prefix'] .
                      $currencies->display_price($new_attributes_price, zen_get_tax_rate($product_info->fields['products_tax_class_id'])) . '</span> ';
					  $onSaleFlag = TRUE;
                    } else {

****Notice I set the flag.

3)Then under RADIO BUTTONS case '6': - line 157 for me but probably closer to 147 on a virgin file?? (I have case six because I am using the MOD "Attribute Image Replaces Main Image" http://www.zen-cart.com/index.php?ma...roducts_id=994)

I have this:

Code:

					  case '6':
                
					 $tmp_attributes_image .= '<!-- attributes '.__LINE__.' --><div class="attribImg">' .zen_draw_radio_field('id[' . $products_options_names->fields['products_options_id'] . ']', $products_options_value_id, $selected_attribute, 'id="' . 'attrib-' . $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id . '"'.' '.$parameters5).'<br />'  . zen_image(DIR_WS_IMAGES . $products_options->fields['attributes_image'],'attr' ,SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, ' border="1" onclick="document.getElementById(\'attrib-'. $products_options_names->fields['products_options_id'] . '-' . $products_options_value_id .'\').checked = true;getattribimage('.'\'id[' . $products_options_names->fields['products_options_id'] . ']\''.','. MEDIUM_IMAGE_WIDTH.','. MEDIUM_IMAGE_HEIGHT.', '.$products_options->fields['products_options_values_id'].','.$_GET['products_id'].');"').  '<br /><!-- attributes '.__LINE__.' -->'. $products_options_details .'<br />'; 	
					if (($products_options->fields['options_values_price'] > '0') && ($onSaleFlag == TRUE)){					 
						 $tmp_attributes_image .= '<!-- attributes '.__LINE__.' --><s>$'. number_format($products_options->fields['options_values_price'],2).'</s>';				 					
					 }	
				 ';		  
					 $tmp_attributes_image .= '</div>' . "\n"; 	 
                      break;

You must make sure that your attributes name is set to Radio and option 6 or this code will never be triggered and another area of attributes.php will need the tweaks applied.

Well it worked for me... good luck and, Ajeh - again thanks for your attentiveness! You're one big reason this board is a great resource.

**Ajeh** · 5 Jan 2010, 03:28 PM

Thanks for posting a solution that worked for on this ...

**pooka** · 20 Jan 2010, 06:19 PM

I started to use the code fix above but got lost on case'6' radio buttons. I'm not using an image for attributes - just radio selection. Problem is "sales or specials" will deduct the price - that's not the problem -- but we want customers to SEE the original price and the sale price, however this is only shown for the FIRST attribute.

I like the way you have code to show the original price and the sale price for ALL the attributes listed.

If we're only using radio buttons - what case "#" is that under attributes.php? And will it still work if we apply it there instead of case6?

Hope this all makes sense.

**Nessuno** · 5 May 2010, 09:52 PM

I'm just writing to say that I had the same problem as OP and other posters on other threads, but no solution helped until I implemented the (vaguely described) sales/specials category bugfix from the thread Ajeh linked.

www.zen-cart.com/forum/showthread.php?t=82619

Fixed instantly with no other changes needed. (I did follow the instruction of setting the master category id to the category I was selecting under SaleMaker prior to doing the bugfix, but that didn't work.)