[Done v1.3.9a] Products Purchased search issue

[paulm]

Zen Cart 1.3.8a default install. Products Purchased report, search feature.

Problem:
After a search it's not possible to do another search without resetting the form. It's minor but annoying (if you can't get used to it, like me ...).

Cause:
The search forms are (opened but) not closed.

// show reset search
    echo zen_draw_form('search', FILENAME_STATS_PRODUCTS_PURCHASED, '', 'get', '', true);
    echo '<br/ >' . HEADING_TITLE_SEARCH_DETAIL_REPORTS_NAME_MODEL . ' ' . zen_draw_input_field('products_filter_name_model') . zen_hide_session_id();
    if (isset($products_filter_name_model) && zen_not_null($products_filter_name_model)) {
      $products_filter_name_model = zen_db_input(zen_db_prepare_input($products_filter_name_model));
      echo '<br/ >' . TEXT_INFO_SEARCH_DETAIL_FILTER . zen_db_prepare_input($products_filter_name_model);
    }
    if (isset($products_filter_name_model) && zen_not_null($products_filter_name_model)) {
      echo '<br/ >' . '<a href="' . zen_href_link(FILENAME_STATS_PRODUCTS_PURCHASED, '', 'NONSSL') . '">' . zen_image_button('button_reset.gif', IMAGE_RESET) . '</a>&nbsp;&nbsp;';
    } else {
      echo '</form>';
    }

Fix:
2x Replace:

    } else {
      echo '</form>';
    }

By:

    }
    echo '</form>';

(2x because the products_id search form has the same problem as the model/name search)

[Sawhorse]

Paulm, just to clarify your corrections. The file you are talking about can be found at public_html/admin/stats_products_purchased.php

The first problem code starts at approx line 72 and is as follows:

// show reset search

    echo zen_draw_form('search', FILENAME_STATS_PRODUCTS_PURCHASED, '', 'get', '', true);

    echo HEADING_TITLE_SEARCH_DETAIL_REPORTS . ' ' . zen_draw_input_field('products_filter') . zen_hide_session_id();

    if (isset($products_filter) && zen_not_null($products_filter)) {

      $products_filter = zen_db_input(zen_db_prepare_input($products_filter));

      echo '<br/ >' . TEXT_INFO_SEARCH_DETAIL_FILTER . $products_filter;

    }

    if (isset($products_filter) && zen_not_null($products_filter)) {

      echo '<br/ >' . '<a href="' . zen_href_link(FILENAME_STATS_PRODUCTS_PURCHASED, '', 'NONSSL') . '">' . zen_image_button('button_reset.gif', IMAGE_RESET) . '</a>&nbsp;&nbsp;';

    } else {

      echo '</form>';

    }

One should change code about line 82 shown above in red to the following:

}
    echo '</form>';

The second and very similar problem code starts at approx line 86 and is as follows:

// show reset search

    echo zen_draw_form('search', FILENAME_STATS_PRODUCTS_PURCHASED, '', 'get', '', true);

    echo '<br/ >' . HEADING_TITLE_SEARCH_DETAIL_REPORTS_NAME_MODEL . ' ' . zen_draw_input_field('products_filter_name_model') . zen_hide_session_id();

    if (isset($products_filter_name_model) && zen_not_null($products_filter_name_model)) {

      $products_filter_name_model = zen_db_input(zen_db_prepare_input($products_filter_name_model));

      echo '<br/ >' . TEXT_INFO_SEARCH_DETAIL_FILTER . zen_db_prepare_input($products_filter_name_model);

    }

    if (isset($products_filter_name_model) && zen_not_null($products_filter_name_model)) {

      echo '<br/ >' . '<a href="' . zen_href_link(FILENAME_STATS_PRODUCTS_PURCHASED, '', 'NONSSL') . '">' . zen_image_button('button_reset.gif', IMAGE_RESET) . '</a>&nbsp;&nbsp;';

    } else {

      echo '</form>';

    }

One should again change code about line 95 shown above in red to the following:

}
    echo '</form>';

Is my understanding correct?

Sawhorse

[paulm]

Is my understanding correct?

Yes it is

[Sawhorse]

Thanks

Sawhorse