Tax + discount coupon BUG?

[wilt]

hi

yes my fault, I missed a line from the changes you need

line 350

          if ($od_amount['total'] > $order_total) $od_amount['total'] = $order_total; 

just before this line add

          $order_total += $orderTotalTax; 

hopefully that should solve the problem

[ErikAllan]

No, the error remains. The code change does not change anything. I rechecked all the changes in ot_coupon.php and I think I´ve done it right...

/Erik

[ErikAllan]

Sorry!

Now it seems to work! I put the line below instead of obove...

Thank you very much for helping me. Now I just have to check a few other combinations... but this is a giant step forward.

/Erik

[ErikAllan]

Hello again...

Now I get wrong amounts when using a COD fee + a discount coupon. When the discount amount is the same (or near) as the subtotal of the products, the cod fee suddenly disappears without reason. See attachements.

/Erik

[wilt]

this could be a fix for that

http://www.zen-cart.com/forum/showthread.php?t=106831

[ErikAllan]

Hi wilt

The code change does not fix my problem. Did I do right if I changed the function in /includes/classes/order_total.php?

But it seems to be a similar problem...

/Erik

[wilt]

hi,

I realised what the real problem is, and its not related to the bug I mentioned. Although putting that bugfix in is still OK.

The problem is that if a Coupon is used to pay the whole order, then the payment method is set to 'GV/Coupon'

So because the payment method is no longer set to COD, no COD fee will be charged.

There may be ways to work around this, if you really want to charge COD on orders where the balance is 0.

[ErikAllan]

Hi again

I could live with no COD fee for orders where the balance is 0. But the strange thing is that the balance does not have to be 0 for this to happen. If I use a discount coupon set to $99 (when having a balance of $100), the cod fee disappears too. See attachments. When applying a 99% discount, everything is fine.

I don´t know the exact limit when the cod fee disappears, but I think it differs if I change the tax to something else than 7%...

/Erik

[ErikAllan]

Hi,

Came across another problem (bug) when applying a flat shipping fee of $10 ($10.7 including tax). The tax is not specified in checkout when the order balance is 0 after applying a discount coupon. Do you know how to fix it? See attachments.

My ot_coupons settings are still: include_shipping = FALSE, include_tax = FALSE, recalculate_tax = Standard

/Erik

[ErikAllan]

Hello again

I think the "low balance when using a discount coupon problem" mentioned earlier is a really nasty bug. The big problem is that the payment method is dropped. The customers are allowed to the following:

1. Put a $1000 product into the cart.
2. Go to checkout.
3. Select a shipping method (ex. flat rate).
4. Use a coupon worth $940 and select payment method (ex. credit card).
5. Confirm the order without beeing redirected to the 3rd party credit card payment site...

See attached file.

Am I doing something wrong? Many people must have the same basic setup and experience similar problems!?

Should I post this as a separate thread?

Best Regards

/Erik