[Done v1.3.9] Newsletter Sign up Check Box Bug

[StoneColdMagic]

Version:
Zen Cart 1.3.8a
Database Patch Level: 1.3.8

Site updates: None

Addons: SEO URLs

I've been using Zen Cart for about 4 or 5 months now.

I've recently discovered something that I cannot find a solution for anywhere online, and I've looked for a few weeks now.

I'm hoping someone can help. Here's the problem. It's regarding the "sign up for newsletter" check box:

If I set the default display to show the box as checked (Admin >> Configuration >> Show Newsletter Checkbox >> 2), when the user creates an account, unchecking it still inserts a value of 1 (TRUE) in the customers.customers_newsletter field.

However, if I set the default display to show the box as unchecked (Admin >> Configuration >> Show Newsletter Checkbox >> 1), then it works as it should (checking is inserts a 1 and leaving it unchecked inserts a 0).

I'm a mid-level php programmer, and I've dug through the files and cannot figure it out. Any help would be much appreciated.

Thanks. The site is:

www.stonecoldmagic.com

[DrByte]

Confirmed as a bug in v1.3.8.
Fixed in v2.0 and 1.3.9

[DrByte]

/includes/modules/create_account.php
Around line 28 you'll need to change this:

  $newsletter = (ACCOUNT_NEWSLETTER_STATUS == '1' ? false : true);

to:

  $newsletter = (ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '0' ? false : true);

And then around line 70 or so you'll see a block of code that looks like this:

    if (isset($_POST['newsletter'])) {
      $newsletter = zen_db_prepare_input($_POST['newsletter']);
    }

Change that to look like this:

  if (ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '2') {
    $newsletter = 0;
    if (isset($_POST['newsletter'])) {
      $newsletter = zen_db_prepare_input($_POST['newsletter']);
    }
  }

This will be included in the upcoming v1.3.9 release. The v2.0 fix is actually very different due to a feature change.