[Done 2.0] Update Cart button incorrectly displayed (1.3.8a)

[Alex Clarke]

I've just noticed that the Update Cart button is displayed on the shopping_cart page when Show Shopping Cart - Update Cart Button Location is set to 1 or 3 in the admin and Products Quantity Box Shows is set to No, Do not show Quantity Box for the product in question.

This button should not display (next to each product) if the quantity box is not visible.

Please let me know if you require any further information.

All the best,

Alex

[Get Em Fast]

Yea, alex, could you give us your URL? And maybe a .........."see that button there?......it shouldn't be there".................or something like that?

[Alex Clarke]

I'm currently working on a development server so cannot provide a URL.

However, I'll try to replicate this issue with a fresh install of 1.3.8a, which should be good enough.

I'll post back with an update soon.

Regards,

Alex

[Get Em Fast]

Sure, that should work if you can duplicate the problem. Let us know when you get it set up.

[DrByte]

Two possible changes:

This one will remove the incorrect "update" button next to un-editable quantities on individual lines/rows in the cart:
/includes/modules/pages/shopping_cart/header_php.php
around line 140 add && !$showFixedQuantity as shown here:

  $buttonUpdate = ((SHOW_SHOPPING_CART_UPDATE == 1 or SHOW_SHOPPING_CART_UPDATE == 3) && !$showFixedQuantity ? zen_image_submit(ICON_IMAGE_UPDATE, ICON_UPDATE_ALT) : '') . zen_draw_hidden_field('products_id[]', $products[$i]['id']);

The following change should only be made if all your products are set to not allow quantity editing, as it does NOT take into consideration the fact that you might have a *mixed* combination of editable vs non-editable options in your cart ... so, use with caution:
/includes/templates/YOUR_TEMPLATE/tpl_shopping_cart_display.php
similar change, but with additional parentheses:

<?php
// show update cart button
  if ((SHOW_SHOPPING_CART_UPDATE == 2 or SHOW_SHOPPING_CART_UPDATE == 3) && !$showFixedQuantity) {
?>

[Alex Clarke]

Hi DrByte,

Sorry for not being able to test this on a clean install of 1.3.8a.

Looks like you've got things sorted!

Thanks for the fix. :)

All the best,

Alex
Posted via Mobile Device