Partial Refund Cancels Order

[chabates]

For some reason my partial refund requests from zencart admin are getting denied by paypal.

So i am going into paypal and issuing partial refunds, but now my orders are disappearing from zencart after the refund. Whats going on?

[chabates]

bummmmpp

[DrByte]

They're not getting deleted. It seems like your PayPal module's refund-status must be blank or set to 0 instead of 1-Pending.

To fix the order so it still shows in your admin list, you'll need to do a search for the order, open it, and change the status to 1-Pending, from the pulldown list, and uncheck the "notify customer" box, and submit. Then it should show back in your list again.

[chabates]

I searched for the order and it said that it was set to "pending" (I have changed the status names), but I updated it to pending again and now it has re-appeared. Can i fix the modules code to update it to pending instead of whatever it tired to do? or is me changing the names the culprit?

[DrByte]

Hmmm .. a tiny bug was causing that.
You can fix it by making the following edit, or upgrading to v139 when it's released (tune in here for release announcements when they're made: )

/includes/modules/payment/paypaldp.php
around line 971 you'll see this block of code. Simply add the new line highlighted as shown:

    /**
     * Submit refund request to PayPal
     */
    if ($proceedToRefund) {
      $response = $doPayPal->RefundTransaction($oID, $txnID, $refundAmt, $refundNote);
      $error = $this->_errorHandler($response, 'DoRefund');
      $new_order_status = ((int)$new_order_status > 0 ? (int)$new_order_status : 1);
      if (!$error) {
        if (!isset($response['GROSSREFUNDAMT'])) $response['GROSSREFUNDAMT'] = $refundAmt;
        // Success, so save the results

You can always recover old orders by using the search+update steps discussed earlier.

[chabates]

awsome ty