Results 1 to 9 of 9
  1. #1
    Join Date
    Dec 2009
    Posts
    55
    Plugin Contributions
    0

    Default [Done 1.3.9b] Yourpay/FirstDATA credit card captures not processing commas correctly

    We've recently noticed that orders over $1000 have been capturing only $1, and $2000+ orders have been capturing $2.

    I believe the issue is that when the sales team captures the money, they copy and paste the number which is $1,xxx.xx or $2,xxx.xx.

    Is this a known issue? Is there a fix for this? I know the obvious solution is to not put the commas in, but I just want to know if there's a way to fix it in the code.

  2. #2
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    What version of Zen Cart?
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Dec 2009
    Posts
    55
    Plugin Contributions
    0

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    I'm currently using 1.3.8a

    Also, I'm only guessing that this is what's causing the issue. If you can think of another reason then by all means.. I'm trying to figure out what's going on

  4. #4
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    /includes/modules/payment/linkpoint_api.php
    around approx line 877 or so you'll see this section of code
    Add the new line as shown:
    Code:
      function _doCapt($oID, $amt = 0, $currency = 'USD') {
        global $db, $messageStack;
        $_POST['captamt'] = preg_replace('/[^0-9.%]/', '', $_POST['captamt']);
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #5
    Join Date
    Dec 2009
    Posts
    55
    Plugin Contributions
    0

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    Thanks so much DrByte!

    Just to be sure, are we not crazy that this is what caused the problem? I just want to make sure that it isn't something else.

  6. #6
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    Yes. It wasn't stripping out characters other than digits and decimal points.
    Granted, now if you were to switch to another currency that uses commas as the decimal indicator you'd be totally broken.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  7. #7
    Join Date
    Dec 2009
    Posts
    55
    Plugin Contributions
    0

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    Thanks again. Good to know, i'll keep that in mind if we ever add different currency.

  8. #8
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    Well, in hindsight, Linkpoint/Yourpay/Firstdata only supports USD anyway, so it's a moot issue at present.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  9. #9
    Join Date
    Dec 2009
    Posts
    55
    Plugin Contributions
    0

    Default Re: Yourpay/FirstDATA credit card captures not processing commas correctly

    Also good to know. We take international orders, but it processes it in USD so... haven't had issues with that yet.

 

 

Similar Threads

  1. Replies: 3
    Last Post: 29 Jun 2013, 08:14 PM
  2. v151 CEON Credit Card Numbers not showing correctly
    By TzuLady in forum Addon Payment Modules
    Replies: 5
    Last Post: 22 Mar 2013, 10:01 PM
  3. FirstData/Linkpoint/YourPay showing First 4 of Credit Card?
    By jsquared in forum Built-in Shipping and Payment Modules
    Replies: 1
    Last Post: 29 Nov 2011, 11:50 PM
  4. Credit card not processing
    By writerguysd in forum Built-in Shipping and Payment Modules
    Replies: 4
    Last Post: 8 May 2010, 07:51 PM
  5. Credit Card Charges not processing
    By MichaelBeranek in forum Addon Payment Modules
    Replies: 3
    Last Post: 10 Oct 2006, 01:50 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR