Page 1 of 3 123 LastLast
Results 1 to 10 of 22
  1. #1
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default [Done v1.3.9e/f] 139c DoExpressCheckoutPayment variables missing

    I noticed the PayPal emails returning sales info were missing the products details. I checked some data and found these variables were not being sent via DoExpressCheckoutPayment when using 139c versus 138.

    L_NUMBER(x)
    L_QTY(x)
    L_NAME(x)
    L_AMT(x)
    L_TAXAMT(x)

  2. #2
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: 139c DoExpressCheckoutPayment variables missing

    It should only skip those kinds of items when there are discounts or calculation problems which would throw off PayPal's validation.

    I'd need to see your detailed PayPalXXXXXXXXXX.log debug log files to know more why it's doing that.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default Re: 139c DoExpressCheckoutPayment variables missing

    OK, see attachment.
    for password see PM
    Last edited by DrByte; 24 May 2010 at 08:52 AM. Reason: removed attachment for privacy

  4. #4
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default Re: 139c DoExpressCheckoutPayment variables missing

    I know this was not marked as fixed for 139d but I though I would see what it does. I installed the boilerplate store with no template changes. Installed PayPal express. Changed the price of an item to one dollar. And made a purchase.

    Still missing. See attachment
    L_NUMBER(x)
    L_QTY(x)
    L_NAME(x)
    L_AMT(x)
    L_TAXAMT(x)

    This information is useful as a backup to the Zen Cart data. And PayPal can use it for "items not as described" complaints.
    Attached Files Attached Files

  5. #5
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default Re: 139c DoExpressCheckoutPayment variables missing

    The following modification fixed the issue for me. I warn it may not fix it for others.

    replace a line 1262 in file paypalwpp.php
    if ($sumofLineItems == 0) {

    with
    if ($sumofLineItems === 0) {


    There must be a difference between being Equal and Identical. Or the change may just shut down the equation altogether and bypass the needed logic. I don't know, not smart enough. I need the line items and am willing to take the chance at the moment.

    Dennis

  6. #6
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default Re: 139c DoExpressCheckoutPayment variables missing

    I may have found the bug.
    Is
    $sumofLineItems
    and
    $sumOfLineItems

    two different varaiables?

  7. #7
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: 139c DoExpressCheckoutPayment variables missing

    Yes, that would be a problem. The uppercase "O" should be used.
    We'll roll that fix into v1.3.9e.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  8. #8
    Join Date
    Jan 2005
    Location
    Tennessee
    Posts
    1,128
    Plugin Contributions
    0

    Default Re: 139c DoExpressCheckoutPayment variables missing

    Dennis does the happy fat man dance around the house. Happy to make the find.

  9. #9
    Join Date
    Jul 2010
    Posts
    1
    Plugin Contributions
    0

    Default Re: [Done v1.3.9e] 139c DoExpressCheckoutPayment variables missing

    Thank You Stagebrace ! Recently upgraded from 1.3.8a to 1.3.9d and found that order details were now missing from PayPal packing slips. Correcting the misspelling of the variable $sumOfLineItems solved the problem immediately. My PayPal packing slips are important to the business and now they work correctly.

  10. #10
    Join Date
    Jan 2004
    Location
    N of San Antonio TX
    Posts
    9,151
    Plugin Contributions
    11

    Default Re: [Done v1.3.9e] 139c DoExpressCheckoutPayment variables missing

    Would that mean the $sumoLineTax should be changed as well?

    Payphone line 606 and others. Seems like same case mistake everywhere sumofLineItems appears.

 

 
Page 1 of 3 123 LastLast

Similar Threads

  1. Some missing data in admin after a port from 138a to 139c
    By Natty in forum Upgrading from 1.3.x to 1.3.9
    Replies: 3
    Last Post: 4 Jun 2010, 09:37 AM
  2. doexpresscheckoutpayment not getting to PP
    By Shoyu Concepts in forum PayPal Express Checkout support
    Replies: 6
    Last Post: 6 May 2008, 08:20 AM
  3. DoExpressCheckoutPayment not working
    By SoundWave13 in forum PayPal Express Checkout support
    Replies: 1
    Last Post: 5 May 2008, 06:26 PM
  4. [Done] 1.3.5 - Project variables not displayed
    By virtualahmad in forum Bug Reports
    Replies: 4
    Last Post: 4 Sep 2006, 02:51 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR