Coupons, some bugs?

[DrByte]

Try this:
Edit /includes/modules/order_total/ot_coupon.php
Line 476 says this:

    $order_total = array('totalFull'=>$orderTotalFull, 'total'=>$order_total, 'tax'=>$order_total_tax, 'totalInclusive'=>$orderTotalInclusive);

Change that to this (note the extra lines added too):

    global $currencies;
    $prec = $currencies->get_decimal_places();
    $order_total = array('totalFull'=>zen_round($orderTotalFull, $prec), 'total'=>zen_round($order_total, $prec), 'tax'=>zen_round($order_total_tax, $prec), 'totalInclusive'=>zen_round($orderTotalInclusive, $prec));

[rued]

In that scenario, with a 1000 product, and flat-rate shipping, and setting the ot_coupon module's "Include Shipping" option to false it rejects the 1000 coupon. With the "Include Shipping" option to true, it accepts the coupon.

Yes, but then it includes shipping. And gives discount on a lower amount than intended. We normaly don't want to give discount on the shipping price, only on the products total.

Do you follow my thinking?

Btw! Also discovered same problem, other way around on group pricing - where the customers gets to high discount.

[rued]

With include shipping the coupon will work on:

Sub-Total: Kr.993,75,-

Flat Rate (Best Way): Kr.6,25,-

Discount Coupon: 10off : -Kr.100,00,-

Incl. 25% MVA: Kr.180,00,-

Total: Kr.900,00,-

And when the shipping cost then is 15-25% of the order total ...

[rued]

If so, then the line which you subsequently commented out wouldn't be firing, thus not impacting you, and thus that line is unrelated to your problems.

Did a test now, added:

print_r($this->include_shipping);

before:

if ($this->include_shipping != 'true') $order_total -= $order->info['shipping_cost'];

Output of that is 'truetruetrue', and not 'true' - seems like it's one 'true' for all shipping modules activated. Normal ...? Do you still belive it's not firing.

[rued]

{Deleted content, doing new test}

[rued]

Some new tests made, with include shipping off.
In this tests the shipping tax is Kr.30, and it seems like this is the amount giving the problems. Why it's removed from total I don't know, but it surly seems to happen without any logic in it.

This works:

Sub-Total: Kr.1.030,00,-
Flat Rate (Best Way): Kr.150,00,-
Discount Coupon: 10off : -Kr.100,00,-
Incl. 25% MVA: Kr.215,40,-
Total: Kr.1.080,00,-

This works NOT:

Sub-Total: Kr.1.029,00,-
Flat Rate (Best Way): Kr.150,00,-
Incl. 25% MVA: Kr.235,80,-
Total: Kr.1.179,00,-

[rued]

Another strange one.
If setting include shipping off and include tax true (re-calculate tax none), the coupon code (10% off) will work on a product with price 1000 - but give wrong discount amount.

Sub-Total: Kr.1.000,00,-
Flat Rate (Best Way): Kr.150,00,-
Discount Coupon: 10off : -Kr.120,00,-
Incl. 25% MVA: Kr.207,00,-
Total: Kr.1.030,00,-

Sorry, I don't find the logic in any settings and tax handling here

[rued]

New test ... When having include shipping/tax false.

Sub-Total: Kr.1.000,00,-
Flat Rate (Best Way): Kr.150,00,-
Incl. 25% MVA: Kr.230,00,-
Total: Kr.1.150,00,-

    if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];
    print_r($order_total_tax);

Outputs 200

//    if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];
    print_r($order_total_tax);

Outputs 230

The line is truly firing even if include shipping is false.

[DrByte]

We'll look at your shipping concerns again separately.

How did the code fix work for your rounding concerns?

[rued]

More test, reading and debuging done ... and I think I see what you're doing wrong.

Sub-Total: 1000

First you remove shipping tax:

    if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];

On next line you remove all tax, including the already removed shipping tax:

    if ($this->include_tax != 'true') $order_total -= $order->info['tax'];

This gives us:

include shipping = false
order total = 770
order total shipping = 150
order total tax = 200

But then you have line commented, witch we can uncomment and change to re-add the shipping tax:

    if ($this->include_tax != "true" && $this->include_shipping != 'true') $order_total += $order->info['shipping_tax'];

This gives us:

include shipping = false
order total = 800
order total shipping = 150
order total tax = 200

That works for us, but I have not tested other scenarios - like tax handling in US etc..