Coupons, some bugs?

**rued** · 10 Jun 2011, 09:43 AM

Shipping tax is also 25%

**DrByte** · 28 Jul 2011, 09:24 PM

Resolved in v1.5.0BETA

**rued** · 29 Jul 2011, 08:11 AM

Great, will test and also update translations shortly.

Also just bought you quite many cups of coffee now, so you can keep up all your good work now in these stressful days to come.

**DrByte** · 2 Aug 2011, 06:45 PM

Hopefully the stress won't be too crazy

**Thieving_Gypsy** · 17 Jan 2012, 04:32 PM

I've got discount coupon problems with tax too - if these issues are fixed in 1.5, is the order total coupon module backwards compatible with 1.3.9h?

**rued** · 17 Jan 2012, 04:50 PM

You should upgrade your site, not backport the fixes - that's of no use and wasted time. ;)

**Thieving_Gypsy** · 17 Jan 2012, 04:58 PM

Of course I understand that but I'm thnking of a quick fix while we plan the upgrade.

**DrByte** · 17 Jan 2012, 05:35 PM

Originally Posted by Thieving_Gypsy

I've got discount coupon problems with tax too - if these issues are fixed in 1.5, is the order total coupon module backwards compatible with 1.3.9h?

No, it's not a simple backport. Many more files are involved than just coupon order totals.
A proper upgrade is the correct solution.

**Gomlers** · 3 Feb 2012, 02:48 PM

Zen Cart is great in so many ways, but I wish it was easier to update the cart, when mods are installed. Zen cart works OK out of the box, but to make it work GREAT some mods really are needed. e.g. the checkout system, credit note-system and a few other things.

I've spent more than a year to complete my cart the way I want it, with different functionality.
And now when I see I have to update the cart to make the ot_coupon.php do the right math, I really lose my motivation.

Although I absolutely admire your work on Zen Cart, and I know you mean so much to so many people's businesses - mine too! - I wish it was an easier way to update the core-files, without having the problems regarding modifications.

Keep up the good work, and please give me directions on how I can fix the tax/miscalculation-problems in the ot_coupons.php on 1.3.9h, if there is any easier way. :)

**DrByte** · 3 Feb 2012, 05:44 PM

We understand your frustration about upgrades being difficult after you make heavy modifications to the code. v2.0 is being architected in a way that minimizes that pain to almost nil.

In the meantime, your best approach is a proper upgrade. The coupon issue discussed in this thread was affected by numerous parts of the code, in numerous places. Hacking all of those out to apply to a store which, as you say, you've already made significant changes to, will not only be near impossible, but will also make future upgrades even more complicated for you. There are a lot of interdependent systems involved in this calculation matter. Backporting it is not practical -- your time is better spent on upgrading your site, and of course will have numerous other valuable benefits in so doing.