Made paypal transaction ID clickable, please confirm I didn't mess up anything :)

[tj1]

Hi, I think having the paypal transaction ID displayed as clickable would come in very handy.

I'm talking about the payment details shown for paypal IPN, example:
*****
Payer Email: [email protected]
Ebay ID:
Payer ID: ABCDEFG1234567
Payer Status: unverified
Address Status: confirmed
Trans. Type: unique
Trans. ID: 1234567890ABCDEFG
Parent Trans. ID:
*****

I originally intended to ask how to do it, but just before asking I gave it a try and I think I got it right after some trial and error.

I first tried using overrides and editing the file includes/languages/english/modules/payment/paypal.php. That was no good.

After using the developer's tool kit, I thought I might try editing includes/modules/payment/paypal/paypal_admin_notification.php.
I first tried creating an overrides folder so as to not edit the original file directly, but I think overrides don't work here, correct?

So since overrides weren't working, I edited the original file. This is what I changed:

$output .= '<tr><td class="main">'."\n";
$output .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
$output .= '</td><td class="main">'."\n";
$output .= $ipn->fields['txn_id']."\n";
$output .= '</td></tr>'."\n";

to:
$output .= '<tr><td class="main">'."\n";
$output .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
$output .= '</td><td class="main"><a href=https://www.paypal.com/us/vst/id='."";
$output .= $ipn->fields['txn_id'].' target=_blank>'."\n";
$output .= $ipn->fields['txn_id']."\n";
$output .= '</a></td></tr>'."\n";


This is working perfectly, but since my knowledge is very limited, could someone confirm if this is OK to do and that I didn't mess up anything?

Thanks.

[DrByte]

That change shouldn't adversely affect anything else, so if it's working for you, carry on.



EDIT:
Similar changes were added in v1.3.9a

[vita]

Hi, I think having the paypal transaction ID displayed as clickable would come in very handy.

I'm talking about the payment details shown for paypal IPN, example:
*****
Payer Email: [email protected]
Ebay ID:
Payer ID: ABCDEFG1234567
Payer Status: unverified
Address Status: confirmed
Trans. Type: unique
Trans. ID: 1234567890ABCDEFG
Parent Trans. ID:
*****

I originally intended to ask how to do it, but just before asking I gave it a try and I think I got it right after some trial and error.

I first tried using overrides and editing the file includes/languages/english/modules/payment/paypal.php. That was no good.

After using the developer's tool kit, I thought I might try editing includes/modules/payment/paypal/paypal_admin_notification.php.
I first tried creating an overrides folder so as to not edit the original file directly, but I think overrides don't work here, correct?

So since overrides weren't working, I edited the original file. This is what I changed:

$output .= '<tr><td class="main">'."\n";
$output .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
$output .= '</td><td class="main">'."\n";
$output .= $ipn->fields['txn_id']."\n";
$output .= '</td></tr>'."\n";

to:
$output .= '<tr><td class="main">'."\n";
$output .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
$output .= '</td><td class="main"><a href=https://www.paypal.com/us/vst/id='."";
$output .= $ipn->fields['txn_id'].' target=_blank>'."\n";
$output .= $ipn->fields['txn_id']."\n";
$output .= '</a></td></tr>'."\n";


This is working perfectly, but since my knowledge is very limited, could someone confirm if this is OK to do and that I didn't mess up anything?

Thanks.

I have made change in includes/modules/payment/paypal/paypal_admin_notification.php

as advised but it does not work for me.

Please help.

[tj1]

What ZC version are you using? This is not necessary anymore in the latest version, the transaction id is already clickable.
I'm not sure since what version this was implemented standard.

[vita]

Thanks for reply.

I am using 1.3.8a

And using paypal express checkout to receive payments.


Regards

[Kim]

I am using 1.3.8a

May I suggest that instead of making changes to very old, insecure code, you need to upgrade to the current version.

[tj1]

This is quite old so I don't remember exactly. I do still have one website running ZC 1.3.8a and this works just fine.

My original post mentioned PayPal IPN, which is different than PayPal Express.
Checking my modified files, I see I made this change in two files
includes/modules/payment/paypal/paypal_admin_notification.php
includes/modules/payment/paypal/paypalwpp_admin_notification.php

You need to modify the paypalwpp_admin_notification.php, which is the one for PayPal Express.
Change this:

    $outputPayPal .= '<tr><td class="main">'."\n";
    $outputPayPal .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
    $outputPayPal .= '</td><td class="main">'."\n";
    $outputPayPal .= urldecode($response['TRANSACTIONID']) ."\n";
    $outputPayPal .= '</a></td></tr>'."\n";  //'</td></tr>'."\n"; 

to this:

    $outputPayPal .= '<tr><td class="main">'."\n";
    $outputPayPal .= MODULE_PAYMENT_PAYPAL_ENTRY_TXN_ID."\n";
    $outputPayPal .= '</td><td class="main"><a href=https://www.paypal.com/us/vst/id='."";
    $outputPayPal .= urldecode($response['TRANSACTIONID']) .' target=_blank>'."\n";
    $outputPayPal .= urldecode($response['TRANSACTIONID']) ."\n";
    $outputPayPal .= '</a></td></tr>'."\n"; 

[vita]

Thanks a lot that worked great.

I am really scared to upgrade whole zen cart from 1.3.8a to 1.3.9h as it's required manual upgrade and many changes needs to be done.

Can i just upgrade paypal module by copying it from 1.3.9h to 1.3.8a?
It's not big deal to reset up paypal express check out in admin.

Regards

[DrByte]

Can i just upgrade paypal module by copying it from 1.3.9h to 1.3.8a?

No. Those modules use a number of other components of classes and functions etc that are shared by other sections of the code, and mixing up the versions will just create problems for you.
A proper upgrade is the proper solution.

[tj1]

There's one thing I don't like how the paypal express works in 1.3.9h

If I need to do more than one funds capture, I have to go to the paypal website to do the additional funds captures because after I do a funds capture in ZC the 'funds capture box' disappears.