Results 1 to 2 of 2
  1. #1
    Join Date
    Jul 2009
    Location
    Texas
    Posts
    209
    Plugin Contributions
    2

    Default [Duplicate] includes/classes/order.php has invalid HTML

    Zen cart 1.3.9h

    Around Line 962 is some code to display the order total in a table. This table is improperly formated which could cause errors in HTML emails.

    Original Code:
    PHP Code:
        //order totals area
        
    $html_ot .= '<td class="order-totals-text" align="right" width="100%">' '&nbsp;' '</td> ' "\n" '<td class="order-totals-num" align="right" nowrap="nowrap">' '---------' .'</td> </tr>' "\n" '<tr>';
        for (
    $i=0$n=sizeof($order_totals); $i<$n$i++) {
          
    $email_order .= strip_tags($order_totals[$i]['title']) . ' ' strip_tags($order_totals[$i]['text']) . "\n";
          
    $html_ot .= '<td class="order-totals-text" align="right" width="100%">' $order_totals[$i]['title'] . '</td> ' "\n" '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' "\n" '<tr>';
        }
        
    $html_msg['ORDER_TOTALS'] = '<table border="0" width="100%" cellspacing="0" cellpadding="2"> ' $html_ot ' </table>'
    This is the fix:
    PHP Code:
        //order totals area
        
    $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' '&nbsp;' '</td> ' "\n" '<td class="order-totals-num" align="right" nowrap="nowrap">' '---------' .'</td></tr>' "\n";
        for (
    $i=0$n=sizeof($order_totals); $i<$n$i++) {
          
    $email_order .= strip_tags($order_totals[$i]['title']) . ' ' strip_tags($order_totals[$i]['text']) . "\n";
          
    $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' $order_totals[$i]['title'] . '</td> ' "\n" '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' "\n";
        }
        
    $html_msg['ORDER_TOTALS'] = '<table border="0" width="100%" cellspacing="0" cellpadding="2"> ' $html_ot ' </table>'
    Thank you,
    Anthony Taylor

  2. #2
    Join Date
    Jan 2004
    Posts
    66,385
    Blog Entries
    7
    Plugin Contributions
    81

    Default Re: [Duplicate] includes/classes/order.php has invalid HTML

    Already reported multiple times, and fixed in v1.5.0
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. Replies: 1
    Last Post: 9 Oct 2011, 06:24 AM
  2. Version help with admin/includes/classes/order.php
    By Brent in forum General Questions
    Replies: 2
    Last Post: 4 Jan 2011, 03:25 PM
  3. [Done 2.0.0] /includes/classes/shopping_cart.php
    By BlessIsaacola in forum Bug Reports
    Replies: 9
    Last Post: 3 Sep 2007, 08:11 AM
  4. PhP question about a line of code in includes/classes/order.php
    By dbrewster in forum Managing Customers and Orders
    Replies: 12
    Last Post: 1 Feb 2007, 03:30 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR