Enlarge product picture is cutoff

[ideasgirl]

what I meant is that the window that encapsulates the picture cuts off the shoe. But the image itself is fine.

Yes, I know...

The fix is easy: just remove the size adjustment value

Worked like a charm, thanks!

[Crunch]

The code has changed over the years it seems....

But the popup height adjustment is in this part of the code:
(includes\modules\pages\popup_image\jscript_main.php)

  if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1 && window.navigator.userAgent.indexOf('SV1') != -1) {
      i=30; //This browser is Internet Explorer 6.x on Windows XP SP2
  } else if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1) {
      i=0; //This browser is Internet Explorer 6.x
  } else if (window.navigator.userAgent.indexOf('Firefox') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=25; //This browser is Firefox on Windows
  } else if (window.navigator.userAgent.indexOf('Mozilla') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=45; //This browser is Mozilla on Windows
  } else {
      i=80; //This is all other browsers including Mozilla on Linux
  }

Adjustment for FF colored red, and 45 seems to be a better value than the current 25.

Not sure about IE 8 though, probaly it also depends on the users browser (compatibility) settings?

(In FF it also depends if the user settings allow javascript to resize the window. If resizing is disallowed the image will fit)

Thanks for identifying the where the problem was coming from and what file needed to be modified. Changing it to i=45 made negligible difference in Firefox. I had to change it to i=80 and the popup re-sizes perfectly in Firefox showing the entire image (same as in IE and Chrome now).

[ebaobao]

crunch are you saying it fixes it in IE as well? the line in red says specifically firefox on windows. can you clarify?

[Crunch]

Here is an update to my testing using the stock Classic Contemporary Green template.

Issues:

• IE 8: Popup re-size window does not open vertically enough to show the bottom of an image (it's cut off)
  
• IE 9: Popup re-size window opens a bit too much so it shows extra white space below the image
  
• Firefox 6 and prior versions: Popup re-size window does not open vertically enough to show the bottom of an image (it's cut off)

I updated the \includes\modules\pages\popup_image\jscript_main.php file to add IE 8 and IE 9 agents and changed the Firefox value.

Here is how that whole section of the file looks now:

  if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1 && window.navigator.userAgent.indexOf('SV1') != -1) {
      i=30; //This browser is Internet Explorer 6.x on Windows XP SP2
  } else if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1) {
      i=0; //This browser is Internet Explorer 6.x
  } else if (window.navigator.userAgent.indexOf('MSIE 8.0') != -1) {
      i=55; //This browser is Internet Explorer 8.x
  } else if (window.navigator.userAgent.indexOf('MSIE 9.0') != -1) {
      i=30; //This browser is Internet Explorer 9.x
  } else if (window.navigator.userAgent.indexOf('Firefox') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=60; //This browser is Firefox on Windows
  } else if (window.navigator.userAgent.indexOf('Mozilla') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=45; //This browser is Mozilla on Windows
  } else {
      i=80; //This is all other browsers including Mozilla on Linux
  }

These updates above fix these issues with the popup re-size box in IE8, IE9 and Firefox.


NOTE: If your template modifies the behavior of the box somehow you may need to tweak these values a bit. The reason I say this is that the custom template I use (cherry zen) has something screwy in it that pushes the image down in the box leaving white space above the image. So, I have to tweak these values a bit to compensate for that template behavior.

[Ajeh]

Do you have a demo of where you are using these settings?

I am not so sure about the FireFox setting, FireFox 6 is going to have issues with that being so large ...

[Crunch]

I PM'd you.

[Ajeh]

What operating system do you have on your computer?

I am using Windows 7 ...

[Crunch]

Windows 7 Ultimate 64-bit

[Ajeh]

See how these settings work for you:

//  if (navigator.appName == 'Netscape') i=20;
  if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1 && window.navigator.userAgent.indexOf('SV1') != -1) {
      i=30; //This browser is Internet Explorer 6.x on Windows XP SP2
  } else if (window.navigator.userAgent.indexOf('MSIE 6.0') != -1) {
      i=0; //This browser is Internet Explorer 6.x
  } else if (window.navigator.userAgent.indexOf('MSIE 8.0') != -1) {
      i=55; //This browser is Internet Explorer 8.x
  } else if (window.navigator.userAgent.indexOf('MSIE 9.0') != -1) {
      i=30; //This browser is Internet Explorer 9.x
  } else if (window.navigator.userAgent.indexOf('SeaMonkey') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=0; //This browser is SeaMonkey on Windows
  } else if (window.navigator.userAgent.indexOf('Chrome') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=27; //This browser is Chrome on Windows
  } else if (window.navigator.userAgent.indexOf('Safari') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=3; //This browser is Safari on Windows
  } else if (window.navigator.userAgent.indexOf('Firefox') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=38; //This browser is Firefox on Windows
  } else if (window.navigator.userAgent.indexOf('Mozilla') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=45; //This browser is Mozilla on Windows
  } else if (window.navigator.userAgent.indexOf('Opera') != -1 && window.navigator.userAgent.indexOf("Windows") != -1) {
      i=25; //This browser is Opera on Windows
  } else if (window.navigator.userAgent.indexOf('Safari') != -1 && window.navigator.userAgent.indexOf("Macintosh") != -1) {
      i=0; //This browser is Safari on Mac
  } else if (window.navigator.userAgent.indexOf('Firefox') != -1 && window.navigator.userAgent.indexOf("Macintosh") != -1) {
      i=35; //This browser is Firefox on Intel Mac
  } else if (window.navigator.userAgent.indexOf('Opera') != -1 && window.navigator.userAgent.indexOf("Macintosh") != -1) {
      i=13; //This browser is Opera on Intel Mac

  } else {
      i=80; //This is all other browsers including Mozilla on Linux
  }

[Crunch]

Everything looks good, but the image in Firefox 6 is still cutoff. Setting it from 38 to 60 makes it work.