Help removing some empty space?

[Muzz]

Hi There,

I can't figure out where some blank space is coming from to remove from my site.

If you visit:

www.y o d g e e.com.au/birkenstock/women

For example.

You will see the image of the product with the price under it.. however the name of the product is a further 2 lines down.

How/where do I remove this space?

Thanks

[niccol]

It's coming from the file modules/yourtemplate/product_listing.php or modules/product_listing.php.

It looks like you have a modified version of that file so it is hard to comment further. It is not the most straight forward file in the installation so you need to work your way through it and work out where the individual <br/>, which are line breaks, are coming from.

Or alternatively you could go for a fast and pretty nasty hack which would be to add the following to the bottom of stylesheet.css

.centerBoxContentsProducts br+br{
display:none;
}

Not really recommended but it kind of works.

[dbltoe]

They are all under the class centerBoxContent and they are entered as <br> versus the correct <br />. You also have something creating an empty a href in the middle. You probably want to turn the two and three into singles. Remove one after the price and then the <br><br><a href...><br><br> that comes after price. That will leave one <br> between the price and title. You might want to correct the <br /> while there as well.

On another note, a lot of your images have spaces. This is a no-no and will cause a multitude of code warnings.

[Muzz]

Thanks for the response.

I do have column grid module installed.

modules/yourtemplate/product_listing.php

I'm guessing it needs tweaking in here somewhere ?

// Following code will be executed only if Column Layout (Grid Layout) option is chosen

if (PRODUCT_LISTING_LAYOUT_STYLE == 'columns') {

$lc_text = implode('<br />', $product_contents);

$list_box_contents[$rows][$column] = array('params' => 'class="centerBoxContentsProducts centeredContent back"' . ' ' . 'style="width:' . $col_width . '%;"',

'text' => $lc_text);

$column ++;

if ($column >= PRODUCT_LISTING_COLUMNS_PER_ROW) {

$column = 0;

$rows ++;

}

}

// End of Code fragment for Column Layout (Grid Layout) option in add on module

Any suggestions?

Would prefer do it right rather than edit css. Might stuff something else up :)

I couldn't find <br /> or <br> with 2 in a row. In fact there are only <br /> and break; in document.


Thanks

[dbltoe]

Just clicked into a product. You need to add a Please Select Your Size option to be display only and default or a customer can simply click add to cart and you won't know if they really needed the 10 or not.
I would also recommend you take a look at the Fual Slimbox add-on.

[niccol]

this line

$lc_text = implode('<br />', $product_contents);

puts a break between each element of the array. If some of the elements are empty then it will appear that there are two breaks or three in a row. You need to go deeper and find which elements you are not using and remove them from the array first.

the css won't mess anything else up because it only has effect in that div. But you are right that the php solution is better.

(for clarity $product_contents is an array. it has multiple elements. column grid 'amalgamates' the array into a single string by using 'implode' so that all the elements, that would normally be in different chunks, end up in a single string. )

[dbltoe]

Strange... Firebug shows them all as <br>

[niccol]

Oh, and they are <br/> not <br>. They just don't look like it when you view it in developers tools. It's a weird thing that happens in developer's tools, but it does not show like that in the source.

Firebug and developers tools 'clean up' the code in various ways which is not a brilliant feature :-)

[Muzz]

Yes.. looking in chrome it shoes it as <br><br>

This must be how it reads it... was doing my head in.

Thanks for all your help.

I only have a very basic understanding php as it is. Was getting a bit much.

I have used the css edit to resolve for now.

Thanks!

As for The add to cart option I do have this off in my admin. It still displays. I did have this off at some stage but think a mod killed it.

As for fuel slimbox this on. I had ajax image swapper installed on my site. But after another mod install I overwrote a file I shouldn't have and accidently over my back up.

I know I need to fix but don't want to kill my website. Will do this when I have time time create mock local web server.

Thanks again.

[niccol]

Well, if it works it works. As dbltoe rightly says there are other errors on there but, yes, a good way of doing this is to work on a development version of the site. Do find the time to make one - it will save you headaches in the future.

If you want to separate the rows a bit you might try:

.centerBoxContentsProducts{
margin-bottom:20px;
}