Direct Bank Deposit

[dbltoe]

Have a client using Direct Bank Deposit NZ with 1.5.7d and PHP 7.4 with the following error:

[24-Jan-2023 11:13:14 NZ] Request URI: /******/index.php?cmd=orders&page=1&oID=2156&action=update_order&language=NZ, IP address: ******
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:269]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Any thoughts to help them out?

[kokolo]

Hi OldNGrey,
Running on 1.5.8 and PHP 8.0
My IP forced my to upgrade to 1.5.8 because they discontinued support for anything < PP8.0
And no, I now not have a working plugin.
So yes please, I will appreciate your plugins by any means you suggest.
Regards

[OldNGrey]

Have a client using Direct Bank Deposit NZ with 1.5.7d and PHP 7.4 with the following error:

[24-Jan-2023 11:13:14 NZ] Request URI: /******/index.php?cmd=orders&page=1&oID=2156&action=update_order&language=NZ, IP address: ******
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:269]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Any thoughts to help them out?

I think you need to be checking delivery country is set. Try changing approx line 48 from

if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {

to

      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) && isset($order->delivery['country']['id']) ) {

[OldNGrey]

Thank you OldNGrey!
Sure that will work for us too if you got it working om PHP8.2 . Small changes I can do myself.
I "almost" have it working, but damn it, I cannot see what I am doing wrong.
Will appreciate your modules.
Email to [email protected] will be appreciated.
Very much!

I have placed an updated USA module of Direct Bank Deposit in my GitHub. https://github.com/OldNGreyBMR/direct_bank_deposit.

Please try it in a TEST environment.

If it works OK, it shouldn't be much work to create a South African variant for all to use.

[OldNGrey]

I think you need to be checking delivery country is set. Try changing approx line 48 from

if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {

to

      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) && isset($order->delivery['country']['id']) ) {

I have placed an updated NZ module of Direct Bank Deposit in my GitHub. https://github.com/OldNGreyBMR/direc...in/NZ/includes that works with ZC157d and ZC158 with PHP 7.4 to 8.2.

Please try it on a test system and let me know the outcome.

[kokolo]

Thank you OldNGrey!
Loaded the three files from Github and get the following error:

PHP Fatal error: Uncaught Error: Undefined constant "MODULE_PAYMENT_DIRBANKNZ_DESCRIPTION" in /usr/www/users/koineepgvq/zz/includes/modules/payment/dirbanknz.php:35
Stack trace:....

This happens while the payment module list is being constructed and gets to "D"

I don't know why I am battling with such an simple thing. Started to think the problem is deeper because I get the same type of "undefined" error with the Netcash payment module. My shop in now down for some time without a proper payment module...imagine! Shop without a till!

Regards

[OldNGrey]

You missed the essential line in the posting " Please try it on a test system ".

I have updated the 3 NZ files to match changes I made to the AUS code. The "MODULE_PAYMENT_DIRBANKNZ_DESCRIPTION" error I had previously overlooked has been corrected and references to cheques and money orders removed.

The NZ files are in my GitHub repository located at https://github.com/OldNGreyBMR/direc...in/NZ/includes

Copy the files to the correct locations; When the Admin Payment Modules page loads correctly, select "Direct-Bank-Deposit - New Zealand", Remove the Module, then Install it and set the values. This ensures that you are using the most recent version.

Please try it on a test system first before you place it in a production system

[kokolo]

Thank you for you effort. Will test it. Obviously I am not wise enough as yet.

[kokolo]

Hi OldNGrey,
It works perfectly! After I lifted my lazy backside and created a test environment to test first.
As reference I want to use the order number. How can I pick that up?
Can I get it from the session variables?
You don't have to do it, just give me a hint.

[OldNGrey]

As reference I want to use the order number. How can I pick that up?

The order number is appended to the information when the order is confirmed by the customer.
The order number doesn't exist until that moment.
The confirmation email shows the bank details and a Reference eg "Reference: z_Test03-85-8414"; in this case z_Test03 is the customer last name, 85 is the customer ID number, 8414 is the order number.

On the order confirmation screen the customer sees the Reference: where the "%s" will be replaced by the order number.