Direct Bank Deposit

[Vinyl Signs]

Hi - I wonder if there is any way to have the Direct Bank transfer for Australia behave the same as for New Zealand ?
I do not require or want cheques and money orders - or the email notification - just the "Please use the following details to transfer your total order value"
Many Thanks for any guidance on this issue...

[Brent]

For anyone trying to install this when running later versions of PHP it seems you need to make the following change.

\includes\modules\payment\dirbank.php

 class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function dirbank() {
      global $order; 

Needs to be changed to

  class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function __construct() {
      global $order; 

[Elemi]

For anyone trying to install this when running later versions of PHP it seems you need to make the following change.

 class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function dirbank() {
      global $order; 

Needs to be changed to

  class dirbank {
    var $code, $title, $description, $enabled;

// class constructor
    function __construct() {
      global $order; 

Hmmm... my version I downloaded already has this in it for 1.5.7, it appears to have installed okay except that it's not showing up for my customers in the cart.... anyone got any suggestions as to what I may have missed....?

[OldNGrey]

Have you installed it under Admin Payment Modules so it is showing a green button?

I'm using v1.5.3 Aus version with zc157a in test.

If you receive an error re indexes customer_id and customer_last_name not defined I placed

// Undefined index: customer_id, customer_last_name bof
@$id=$_SESSION['customer_id'];
@$ln=$_SESSION['customer_last_name'];
// eof

at the beginning of the code in includes/languages/english/modules/payment/dirbankaus.php

environment Test: Zen Cart 157a; Apache 2.4.46; PHP 7.4.9; MySQL 5.7.31; Windows 10

[Elemi]

Yes, I have the green light showing on the admin page. It doesn't show on the payment options page at all for the customer.... I'm on 1.5.7

[Elemi]

Hmmm... it's a zone thing... it will only accept one of my zones, not the New Zealand Zone...

[OldNGrey]

Dirbank is tied to the Tax Rates defined under Admin | Locations /Taxes | Tax Rates.

The zones referenced are under Admin | Locations/Taxes | Zone Definitions - Taxes, Payment and Shipping
I have created two zones:
first zone is: zone Name = "Australia", Description = "Australia - GST";
under Details: Country=Australia, Zone= All zones
under Tax Rate: Priority=1, Tax Class Title=GST, Zone=Australia [note this references the Zone under zone definitions], tax Rate=10, Description = GST

second zone is: zone-name= "Outside Aus", Description =World-excluding Australia"
under Details: Country= every country except Australia, Zone= All zones
under Tax Rate: Priority=0, Tax Class Title=No Tax, Zone=Outside Aust [note this references the Zone under zone definitions], tax Rate=0, Description = GST Free


So if you have two countries with the same tax rate you can combine them into one Zone.

There must be a green dot against the entries in Zone Definitions - Taxes, Payment and Shipping

Under Admin | Configuration | My Store I have
Basis of Product Tax = Shipping. and
Basis of Shipping Tax = Shipping

so Zen Cart will add tax based on shipping address. Aus customers see Dirbank, Customers outside Aus don't see Dirbank.

[dbltoe]

1.5.7b PHP 7.3.25 MySQL 5.7.32
OPC
Edit Orders
PayPal Express
Zone Shipping
No other Payment or Shipping Mods Installed

Using dirbanknz.php

Warning log

[05-Jan-2021 13:36:10 US/Central] Request URI: /******/index.php?cmd=orders&page=1&oID=1596&action=update_order&language=NZ, IP address: 122.##.###.###
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:266]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Latest code from download of file

// class methods    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKNZ_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }

Assuming the item in red is the problem but not sure of the solution.

[DrByte]

1.5.7b PHP 7.3.25 MySQL 5.7.32
OPC
Edit Orders
PayPal Express
Zone Shipping
No other Payment or Shipping Mods Installed

Using dirbanknz.php

Warning log

[05-Jan-2021 13:36:10 US/Central] Request URI: /******/index.php?cmd=orders&page=1&oID=1596&action=update_order&language=NZ, IP address: 122.##.###.###
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:266]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Latest code from download of file

// class methods    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKNZ_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }

Assuming the item in red is the problem but not sure of the solution.

2 tips:
1. If this store is using this module for "all addresses", eg no zone restrictions, you could just put "return;" as the first line of the update_status() function and skip that part altogether.
2. The parameters passed to the zone lookup query in many older shipping/payment modules' update_status() functions are quite possibly incorrect. Compare with the update_status() function in current built-in shipping/payment modules to see what may be incorrect. It's also easy to test whether the change you make has any undesired side-effects: just test whether the module works both with and without zone restrictions applied for a given address.

[4tinak]

Please help I need the following corrected - see image


Reference - can this be changed to only show the order #?
How do you change MODULE_PAYMENT_DIRBANKAUS_ADDRESS - looks like something is missing.
Can Swift Code be removed?

Thanks for the help!