sqlpatch.php help-text gives "bad" information

[lat9]

Looking through the help-text (by pressing the Details button) for the admin Tools->Install SQL Patches, the first example under "Advanced Methods" specifies the following code block as a guideline:

#NEXT_X_ROWS_AS_ONE_COMMAND:4
SET @t1=0;
SELECT (@t1:=configuration_value) as t1
FROM configuration
WHERE configuration_key = 'KEY_NAME_HERE';
UPDATE product_type_layout SET configuration_value = @t1 WHERE configuration_key = 'KEY_NAME_TO_CHECK_HERE';
DELETE FROM configuration WHERE configuration_key = 'KEY_NAME_HERE';

The SQL fragment highlighted above in red was previously identified by swguy as problematic (http://www.zen-cart.com/showthread.p...es-please-note!) and the source of the "Attribute Required for Text flag not working" issue. As such, the help text should be modified to give the correct usage.

P.S. It would "help" to have the "Details" button renamed to "Help" ...

[DrByte]

The point of the example wasn't the actual SQL at all. It was the use of the "#NEXT_X_ROWS_AS_ONE_COMMAND:4" which tells the script to treat the next 4 lines as one submitted statement, instead of splitting them all up after each ending semicolon.

The actual SQL in the example has no direct affect on attributes in any way.

We'll consider a different example in a future release.

[DrByte]

Further investigation reveals that perhaps the post you quoted from swguy is incorrect.

Running the following code (even without the #NEXT_X_ROWS... instruction) works just fine, thus suggesting that there's nothing wrong with the SQL:

SET SET @t4=0;
SELECT (@t4:=configuration_group_id) as t4 FROM configuration_group WHERE configuration_group_title= 'Images';
UPDATE configuration set configuration_value=@t4 where configuration_key = 'STORE_NAME';
UPDATE configuration set configuration_value=@t4 where configuration_key = 'STORE_OWNER';

(this will set Admin->Configuration->My Store-> store name and store owner to '4'. Naturally you'll want to fix those to their correct values if you run this test.)

So, I must ask: have you actually tested the examples and found a specific problem? Or are you merely pointing out a discrepancy between swguy's suggestion vs the help text provided within Zen Cart?

[swguy]

@lat9: The issue, which is described more fully in http://www.zen-cart.com/showthread.p...178#post993178 is not that the use of this statement is problematic:

SET @t1=0;

It's the use of delete without checking the configuration group id. If you use

DELETE FROM configuration WHERE configuration_group_id = @t4 AND configuration_group_id !=0;
DELETE FROM configuration_group WHERE configuration_group_id = @t4 AND configuration_group_id !=0;

Then you'll be fine.

[lat9]

Thanks for the clarification, swguy ... MySQL is (obviously) not one of my fortes.

As far as this bug-report goes, I believe that the updated example should read:

#NEXT_X_ROWS_AS_ONE_COMMAND:4
SET @t1=0;
SELECT (@t1:=configuration_value) as t1
FROM configuration
WHERE configuration_key = 'KEY_NAME_HERE';
UPDATE product_type_layout SET configuration_value = @t1 WHERE configuration_key = 'KEY_NAME_TO_CHECK_HERE' AND t1 !=0;
DELETE FROM configuration WHERE configuration_key = 'KEY_NAME_HERE' AND t1 !=0;