Converting osc contribution Post code Validation

[vkd1980]

Can any one tell me whats wrong with this function?, I am a Newbie in PHP

Function in "\includes\functions\functions_general.php" to Check

// VALIDATE POSTCODE START
function tep_validate_postcode($country_id, $postcode)
    {
    $postval =$db->Execute( "select countries_postal_validation from countries where countries_id = '" . (int)$country_id . "' limit 1");
    
        if (zen_not_null($postval->fields['countries_postal_validation']))
        {
        return (preg_match($postval->fields['countries_postal_validation'], $postcode));
        }
    else return true;
    }
// VALIDATE POSTCODE END 

Checking of entry in "\includes\modules\pages\address_book_process\header_php.php"

if (strlen($postcode) < ENTRY_POSTCODE_MIN_LENGTH) {
    $error = true;
    $messageStack->add('addressbook', ENTRY_POST_CODE_ERROR);
  }
// VALIDATE POSTCODE START
    if (tep_validate_postcode($country, $postcode) == false)
        {
        $error = true;
        $messageStack->add('addressbook', ENTRY_POST_CODE_VALID_ERROR);
        }
// VALIDATE POSTCODE END 

Thanks in Advance

Vinod

[DrByte]

You can't access the $db variable from inside a function if you don't declare it as a global first.

function name_of_function()
  {
    global $db;
    // rest of code which uses $db goes here
  }

[vkd1980]

You can't access the $db variable from inside a function if you don't declare it as a global first.

function name_of_function()
  {
    global $db;
    // rest of code which uses $db goes here
  }

Thank you DrByte,

gotcha, I just forgot

Uploading the contribution, will be available to download after authorization

[RodG]

Can any one tell me whats wrong with this function?, I am a Newbie in PHP

I note that DrByte has provided the solution, but I do have another very minor suggestion of my own.

function tep_validate_postcode($country_id, $postcode)

My suggestion is to change "tep_validate_postcode" to "zen_validate_postcode" (in every place it is referenced).

Although this will make NO DIFFERENCE to functionality, the change will serve several purposes.
Firstly it will make the code follow the zencart coding standards.
Secondly it will obfuscate the fact that this was a direct port from an OsCommerce module
Thirdly, in the odd chance you ever need to perform a global search for zencart functions using the 'zen_' prefix it will assure that your function will be found along with all the other zen_ functions.

As I say, it's not a big deal, and it's not worth rushing out to make the change. It's just something to keep in mind and possibly implement if/when you need to make other changes.

Cheers
Rod

[DrByte]

or better yet, maybe "vkd_" would be better than "zen_" since it's not really a Zen Cart function.

[vkd1980]

or better yet, maybe "vkd_" would be better than "zen_" since it's not really a Zen Cart function.

My suggestion is to change "tep_validate_postcode" to "zen_validate_postcode" (in every place it is referenced).

Me Also Agree,

I will Change the function Name to "zen_validate_postcode" and will upload fresh file soon,

Dear Moderator,

Please reject the current file uploaded

Vinod