Edit Orders v4.0 Support Thread

[lat9]

I've got a close-to-release version (v4.4.0-beta5) of Edit Orders now staged on GitHub: https://github.com/lat9/edit_orders/...g/v4.4.0-beta5

Please note that this is a beta version, not yet intended for live site integration! I'd appreciate any/all 3rd-party validation that the community can provide, with issues found reported via GitHub, please.

Here's the list of issues currently staged for update by that release: https://github.com/lat9/edit_orders/...stone%3Av4.4.0

Updated the beta version to v4.4.0-beta10 (https://github.com/lat9/edit_orders/.../v4.4.0-beta10). This beta-release, which I now consider a release-candidate, corrects various tax-handling issues and adds notifications to enable other plugins to interoperate without changing the base files.

My plan is to release v4.4.0 later this week! Thanks to all the people that have provided additional testing and feedback!

[jvdd]

Can't seem to anyone with the same problem as I do.

I can normally edit an order (quantity, add new product, comment, status, etc.) with no problem. Recently a HUGE order came in with over 400 items and can't be edited. Clicking update gives me a blank page that has the all the admin header, nav and footer and nothing else. I can add an item and it updates but not edit existing items.

debug_edit _orders_xxx.log ends with just this:

2019-05-31 15:03:13, Edit Orders entered (4.3.4) action (update_order)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php ;ot_total.php

2019-05-31 08:58:11, Edit Orders entered (4.3.4) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php;ot_total.php
getOrderInfo, on entry: Called by /…/…/…/…/edit_orders.php on line #705
	Subtotal: (not set), Shipping: (not set), Shipping Tax: (not set), Tax: XXXX.XX, Total: XXXXX.XX, Tax Groups: {"15.0000":"1"}
	$_SESSION['shipping']: (not set)

Order Totals
		ot_subtotal. Text: $XX,XXX.XX, Value: XXXXX.XXXX
		ot_tax. Text: $X,XXX.XX, Value: XXXX.XXXX
		ot_shipping. Text: $0.00, Value: 0.0000
		ot_total. Text: $XX,XXX.XX, Value: XXXXX.XXXX

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual


getProductTaxes(15.0% HST)
{"products_tax_class_id":"1"}{"qty":2,"id":"653","name”:”Product Name”,”model”:”XXX-XX”,”tax":"15.0000","price”:”XX.XXXX”,”final_price”:”XX.XXXX”,”onetime_charges":"0.0000","products_priced_by_attribute":"1","product_is_free":"0","products_discount_type":"0","products_discount_type_from":"0","attributes":[{"option":"Color","value":"Amber","option_id":"1","value_id":"16","prefix":"+","price":"0.0000"}]}
getProductTaxes, returning 8.1.
…..… LONG LIST……..

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual
calculateOrderShippingTax returning 0.
getOrderInfo, on exit:
{"code":"delivertocustomer","title":"Delivery","description":"Deliver to Customer","icon":"","enabled":true,"sort_order":"0","tax_class":"0","tax_basis":"Shipping"}
	Subtotal: XXXXX.X, Shipping: 0, Shipping Tax: 0, Tax: XXXX.XX, Total: XXXXX.XX, Tax Groups: {"15.0% HST”:XXXX.XX}
	$_SESSION['shipping']: {"title":"Delivery (Shipping costs will be calculated for final invoice)","id":"delivertocustomer_","cost":0}

Order Totals
		ot_subtotal. Text: $XX,XXX.XX, Value: XXXXX.XXXX
		ot_tax. Text: $X,XXX.XX, Value: XXXX.XXXX
		ot_shipping. Text: $0.00, Value: 0.0000
		ot_total. Text: $XX,XXX.XX, Value: XXXXX.XXXX

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual


============================================================
= Creating display of Order Product #2311
============================================================
Product Details:
{"qty":2,"id":"653","name”:”Product Name”,”model”:”XXX-XX,”tax":"15.0000","price”:”XX.XXXX”,”final_price”:”XX.XXXX”,”onetime_charges":"0.0000","products_priced_by_attribute":"1","product_is_free":"0","products_discount_type":"0","products_discount_type_from":"0","attributes":[{"option":"Color","value":"Amber","option_id":"1","value_id":"16","prefix":"+","price":"0.0000"}]}


Options ID #1
Product Attribute: 
["2682"]
Options Info:
{"options":{"2219":"Assorted","2218":"Amber","2214":"Black","2216":"Blue","2215":"Green","2217":"Pink"},"name":"Color","type":"6","length":"32","size":"32","rows":"0"}

…..… LONG LIST……..

2019-05-31 08:58:54, Edit Orders entered (4.3.4) action (update_order)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php;ot_total.php

[/CODE]

In a successful edit case, it would have the regular product and details populated after that. Help?!

ZC 1.5.5f
EO 4.3.4
Group Pricing (per Item) 155
Stock by Attributes" (version 1.5.3)
Admin New Order 1.4
Add Customers From Admin 2.0.9

[Dustie]

Can't seem to anyone with the same problem as I do.

I can normally edit an order (quantity, add new product, comment, status, etc.) with no problem. Recently a HUGE order came in with over 400 items and can't be edited. Clicking update gives me a blank page that has the all the admin header, nav and footer and nothing else. I can add an item and it updates but not edit existing items.

debug_edit _orders_xxx.log ends with just this:

2019-05-31 15:03:13, Edit Orders entered (4.3.4) action (update_order)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php ;ot_total.php

2019-05-31 08:58:11, Edit Orders entered (4.3.4) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php;ot_total.php
getOrderInfo, on entry: Called by /…/…/…/…/edit_orders.php on line #705
	Subtotal: (not set), Shipping: (not set), Shipping Tax: (not set), Tax: XXXX.XX, Total: XXXXX.XX, Tax Groups: {"15.0000":"1"}
	$_SESSION['shipping']: (not set)

Order Totals
		ot_subtotal. Text: $XX,XXX.XX, Value: XXXXX.XXXX
		ot_tax. Text: $X,XXX.XX, Value: XXXX.XXXX
		ot_shipping. Text: $0.00, Value: 0.0000
		ot_total. Text: $XX,XXX.XX, Value: XXXXX.XXXX

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual


getProductTaxes(15.0% HST)
{"products_tax_class_id":"1"}{"qty":2,"id":"653","name”:”Product Name”,”model”:”XXX-XX”,”tax":"15.0000","price”:”XX.XXXX”,”final_price”:”XX.XXXX”,”onetime_charges":"0.0000","products_priced_by_attribute":"1","product_is_free":"0","products_discount_type":"0","products_discount_type_from":"0","attributes":[{"option":"Color","value":"Amber","option_id":"1","value_id":"16","prefix":"+","price":"0.0000"}]}
getProductTaxes, returning 8.1.
…..… LONG LIST……..

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual
calculateOrderShippingTax returning 0.
getOrderInfo, on exit:
{"code":"delivertocustomer","title":"Delivery","description":"Deliver to Customer","icon":"","enabled":true,"sort_order":"0","tax_class":"0","tax_basis":"Shipping"}
	Subtotal: XXXXX.X, Shipping: 0, Shipping Tax: 0, Tax: XXXX.XX, Total: XXXXX.XX, Tax Groups: {"15.0% HST”:XXXX.XX}
	$_SESSION['shipping']: {"title":"Delivery (Shipping costs will be calculated for final invoice)","id":"delivertocustomer_","cost":0}

Order Totals
		ot_subtotal. Text: $XX,XXX.XX, Value: XXXXX.XXXX
		ot_tax. Text: $X,XXX.XX, Value: XXXX.XXXX
		ot_shipping. Text: $0.00, Value: 0.0000
		ot_total. Text: $XX,XXX.XX, Value: XXXXX.XXXX

	Checking whether the product's attribute is a download, option_id = 14, value_id = 196: (1)
	…..… LONG LIST……..

Checking order for virtual status.  Order contains 453 unique products, 0 of those are virtual


============================================================
= Creating display of Order Product #2311
============================================================
Product Details:
{"qty":2,"id":"653","name”:”Product Name”,”model”:”XXX-XX,”tax":"15.0000","price”:”XX.XXXX”,”final_price”:”XX.XXXX”,”onetime_charges":"0.0000","products_priced_by_attribute":"1","product_is_free":"0","products_discount_type":"0","products_discount_type_from":"0","attributes":[{"option":"Color","value":"Amber","option_id":"1","value_id":"16","prefix":"+","price":"0.0000"}]}


Options ID #1
Product Attribute: 
["2682"]
Options Info:
{"options":{"2219":"Assorted","2218":"Amber","2214":"Black","2216":"Blue","2215":"Green","2217":"Pink"},"name":"Color","type":"6","length":"32","size":"32","rows":"0"}

…..… LONG LIST……..

2019-05-31 08:58:54, Edit Orders entered (4.3.4) action (update_order)
Enabled Order Totals: ot_subtotal.php;ot_misc_cost.php;ot_group_pricing.php;ot_tax.php;ot_shipping.php;ot_total.php

[/CODE]

In a successful edit case, it would have the regular product and details populated after that. Help?!

ZC 1.5.5f
EO 4.3.4
Group Pricing (per Item) 155
Stock by Attributes" (version 1.5.3)
Admin New Order 1.4
Add Customers From Admin 2.0.9

Not sure if I am the right person to reply, or if my reply is correct, but I had the same problem editing existing items. To edit items you need to go to -configuration / Edit Orders and then change both *Product Price Calculation — Method and Default to MANUAL!

Hope this helps and otherwise hopefully someone else can help :)

[lat9]

@jvdd, there was most likely an associated /logs/myDEBUG-adm-*.log file on/around the time of that EO log. My guess is that the processing is running out of memory, but a log will 'say' for sure.

Remember, if you're posting an admin log that it will contain your store's secret admin directory name, so be sure to xxx-out any path information before posting.

[lat9]

I've just submitted v4.4.0 of Edit Orders to the Zen Cart Plugins for review; I'll post back when it's available for download.

This major release contains changes and corrections for the following GitHub issues:


#61: Order total doesn't add up when coupon applied.
#79: Incorrect total for products with attributes, when initially added; requires 'update' to correct.
#88: Remove double-definition of language constant.
#89: Add notifiers to enable external tax-handling.
#90: Correct various PHP warnings and notices.
#91: An extra ':' is added to the end of the shipping title.
#93: Correct tax-handling for 'ot_misc_cost' and 'ot_onetime_discount' order totals.
#94: Modify array formatting for EO logs.
#95: Correct rounding issues.
#97: Correct 'ot_misc_cost' rounding issues.
#98: No longer distribute core file changes; they're built into Zen Cart 1.5.6b and later.
#99: Can't update an order with automatic pricing, using specials' pricing.
#101: Use zc156 button styling when installed on a zc156 base.
#102: Enable integration with "Attribute Image Swapper".
#103: Modify shipping tax-related processing.
#104: Always use the 'mock' cart.
#105: Add a status-history note to the order each time the order is updated or a product is added.
#106: Coupon-related corrections.
#108: Additional notification, allowing customization of display-only order totals.
#109: Additional configuration settings (see the readme for more information).
#110: Additional notification, allowing the inclusion of additional javascript/jQuery scripts.
#112: Additional notification, enabling additional columns to the order's status-history table.
#113: Don't reset shipping calculations when totals are reset.
#114: Sanitize input values and maximum field lengths.
#116: Even more notifications added, to enable additional customizations without changing the base file.
#117: Include an 'Updated By' column in the status-history table, if that field is present in the database.
#119: Correct missing constant for 'ot_onetime_discount'
#120: Supply missing 'ot_coupon' constant for zc156b beta installations.


Compatible with zc155 and zc156 installations.

[lat9]

I've just submitted v4.4.0 of Edit Orders to the Zen Cart Plugins for review; I'll post back when it's available for download.

This major release contains changes and corrections for the following GitHub issues:


#61: Order total doesn't add up when coupon applied.
#79: Incorrect total for products with attributes, when initially added; requires 'update' to correct.
#88: Remove double-definition of language constant.
#89: Add notifiers to enable external tax-handling.
#90: Correct various PHP warnings and notices.
#91: An extra ':' is added to the end of the shipping title.
#93: Correct tax-handling for 'ot_misc_cost' and 'ot_onetime_discount' order totals.
#94: Modify array formatting for EO logs.
#95: Correct rounding issues.
#97: Correct 'ot_misc_cost' rounding issues.
#98: No longer distribute core file changes; they're built into Zen Cart 1.5.6b and later.
#99: Can't update an order with automatic pricing, using specials' pricing.
#101: Use zc156 button styling when installed on a zc156 base.
#102: Enable integration with "Attribute Image Swapper".
#103: Modify shipping tax-related processing.
#104: Always use the 'mock' cart.
#105: Add a status-history note to the order each time the order is updated or a product is added.
#106: Coupon-related corrections.
#108: Additional notification, allowing customization of display-only order totals.
#109: Additional configuration settings (see the readme for more information).
#110: Additional notification, allowing the inclusion of additional javascript/jQuery scripts.
#112: Additional notification, enabling additional columns to the order's status-history table.
#113: Don't reset shipping calculations when totals are reset.
#114: Sanitize input values and maximum field lengths.
#116: Even more notifications added, to enable additional customizations without changing the base file.
#117: Include an 'Updated By' column in the status-history table, if that field is present in the database.
#119: Correct missing constant for 'ot_onetime_discount'
#120: Supply missing 'ot_coupon' constant for zc156b beta installations.


Compatible with zc155 and zc156 installations.

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1513

[jvdd]

@jvdd, there was most likely an associated /logs/myDEBUG-adm-*.log file on/around the time of that EO log. My guess is that the processing is running out of memory, but a log will 'say' for sure.

Remember, if you're posting an admin log that it will contain your store's secret admin directory name, so be sure to xxx-out any path information before posting.

Thanks for replying. I archived and reset the logs before that date and haven't gotten any new error log files after that. The reason why I enabled the EO logs was to see if there were any indication of errors.

[jvdd]

@Dustie

I don't even see what you are referring to in the configuration settings?!!

Only see the following:

Edit Orders Version (4.3.4)
Reset Totals on Update — Default (on)
Use a mock shopping cart? (false)
Strip tags from the shipping module name? (true)
Debug Action Level (1)

Should I also see 'Product Price Calculation'?

[jvdd]

@jvdd, there was most likely an associated /logs/myDEBUG-adm-*.log file on/around the time of that EO log. My guess is that the processing is running out of memory, but a log will 'say' for sure.

Remember, if you're posting an admin log that it will contain your store's secret admin directory name, so be sure to xxx-out any path information before posting.

Sorry, I apologize for not mentioning a couple of logs before the EO issue mentioned. They have been resolved and therefore archived and reset. I don't believe they are related.

[30-May-2019 12:10:46 America/Toronto] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 72 bytes) in /.../.../.../.../developers_tool_kit.php on line 164

and

[30-May-2019 16:51:16 America/Toronto] Request URI: /index.php?main_page=checkout_confirmation, IP address: XX.XX.XX.XXX
#1  currencies->display_price() called at [/.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php:201]
#2  require(/.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php) called at [/.../.../.../includes/templates/.../common/tpl_main_page.php:183]
#3  require(/.../.../.../includes/templates/.../common/tpl_main_page.php) called at /.../.../.../index.php:97]

[30-May-2019 16:51:16 America/Toronto] PHP Warning:  Missing argument 2 for currencies::display_price(), called in /.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php on line 201 and defined in /.../.../.../includes/classes/currencies.php on line 123

[lat9]

@jvdd, neither of those logs is EO related. The first is from the "Developers' Tool Kit" and the other is from the storefront checkout_confirmation page.