Edit Orders v4.0 Support Thread

[mc12345678]

The problem is this test
if (defined ('PROJECT_VERSION_MAJOR') && version_compare (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR, '1.5.5', '>=') && class_exists ('AdminRequestSanitizer') && method_exists ('AdminRequestSanitizer', 'getInstance')) {

1.5.5a will fail as version_compare("1.5.5a", "1.5.5") = -1

drbyte suggests

(int)(PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR <= '1.5.5');

Considering that this "feature" was considered to be applied to 1.5.5.a and future versions, I would suggest:

if (defined ('PROJECT_VERSION_MAJOR') && (version_compare (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR, '1.5.5.a', '=') || version_compare (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR, '1.5.5', '>')) && class_exists ('AdminRequestSanitizer') && method_exists ('AdminRequestSanitizer', 'getInstance')) {

[DrByte]

Strictly speaking, this is enough: class_exists ('AdminRequestSanitizer') && method_exists ('AdminRequestSanitizer', 'getInstance')

[swguy]

Yes - this logic was intended to be added to all 1.5+ carts.
https://www.zen-cart.com/showthread....d-TWSL2016-006

[lat9]

Strictly speaking, this is enough: class_exists ('AdminRequestSanitizer') && method_exists ('AdminRequestSanitizer', 'getInstance')

Thanks, DrByte; I'll get that change incorporated.

Yes - this logic was intended to be added to all 1.5+ carts.
https://www.zen-cart.com/showthread....d-TWSL2016-006

Arggh, I'd seen that posting but hadn't "looked under the covers". Here's hoping that some store owner doesn't blindly install that patch on a store that uses Edit Orders (and possibly other plugins that don't yet know that they're broken)! Would it be possible to update that posting to provide some modicum of caution, possibly specifically referencing Edit Orders?

[lat9]

I've got the change above incorporated and created a 4.1.5-beta2 distribution as it seems that we're getting closer to having a releasable version!

[swguy]

I think the way to go is just to update and improve the patch (using the fixes that you, wilt and DrByte have provided) so this isn't an issue.

There is another mod somewhere that also breaks Edit Orders when combined with even this updated patch, but I haven't isolated it.

[lat9]

---Quote (Originally by swguy)---
I think the way to go is just to update and improve the patch (using the fixes that you, wilt and DrByte have provided) so this isn't an issue.

There is another mod somewhere that also breaks Edit Orders when combined with even this updated patch, but I haven't isolated it.
---End Quote---
There are a fair number of "order totals" that are actually "shopping-cart and/or customer-session totals" that break Edit Orders (which has access to neither), so that's not new news.

[lat9]

I am aware of that - this is different. And when I say "breaks" I mean breaks in the "missing attributes" sense I had reported earlier.

I just pushed a couple of fixes to EO - navigation at the top was wrong and there was a missing bracket in a sanitizer.

@swguy, Why are you editing my posts?

I've updated the EO GitHub repository to correct the missing parentheses (it's now at v4.1.5-beta3).

Your "fix" to the navigation is a "change" to the navigation that's been in EO forever, so it's not going to be changed in the EO repository. You're welcome to make that change to your installation.

[swguy]

There are a fair number of "order totals" that are actually "shopping-cart and/or customer-session totals" that break Edit Orders (which has access to neither), so that's not new news.

I am aware of that - this is different. And when I say "breaks" I mean breaks in the "missing attributes" sense I had reported earlier.

I just pushed a couple of fixes to EO - navigation at the top was wrong and there was a missing bracket in a sanitizer.

[swguy]

@swguy, Why are you editing my posts?

Finger trouble. Sorry about that - I have no idea what happened but I have restored the original content.