[Fixed 1.6.0] ez pages toc links not displaying any more

[artworkz]

My earlier site which has been in stasis since end of May, when I migrated to a new server....both of my sites are the same 1.3.9.h, apart from the following changes, mainly to ensure faster operation.....here's my changelog

27/6/12
php.ini added at root to define mysqli default socket
15/06/12
modded sessions database table to innoDB
GZip turned on
modded whos_online table to innoDB
Get rid of products_viewed stats /includes/modules/pages/product_info/main_template_vars.php
removed the line with the update ( it should be line 39-42)

added mod Query Cache (data diggers)
caching improvements from Zen info pages added to includes/.htaccess
29/09/12
modded in includes/modules/pages/page/header_php.php
$pages_listing = $db->execute($pages_order_query); moved 5 lines lower as quick fix for table of contents bug conflict

Both sites use image handler 2, stock by attributes, zen lightbox, uk postcode shipping mods...

And both sites show the same behaviour...

[wilt]

confused.

I asked if you had datadiggers query cache installed and you said no.

Hi Wilt...no query cache installed for me..have asked justhost to let me know what upgrades they did on the server...should hear soon

and now you say you do have it installed

Get rid of products_viewed stats /includes/modules/pages/product_info/main_template_vars.php
removed the line with the update ( it should be line 39-42)

added mod Query Cache (data diggers)

[artworkz]

Hi Wilt

sorry...brain fade on that one...just to confirm, then, my legacy site has NO query cache installed....the current live site DOES. Both had the same ToC problem. Apologies....

[DrByte]

I'd like to test what I think is an improvement to the code overall:

/includes/modules/pages/page/header_php.php
change the following:

$pages_listing = $db->execute($pages_order_query);

 while (!$pages_ordering->EOF) {
   $vert_links[] = $pages_ordering->fields['pages_id'];
   $pages_ordering->MoveNext();
 }

to this instead (changing one line, adding another line):

$toc_links = array();


 while (!$pages_ordering->EOF) {
   $vert_links[] = $pages_ordering->fields['pages_id'];
   $toc_links[] = array('pages_id' => $pages_ordering->fields['pages_id'], 'pages_title' => $pages_ordering->fields['pages_title']);
  $pages_ordering->MoveNext();
 }

And also for /includes/templates/YOUR_TEMPLATE_NAME_HERE/templates/tpl_page_default.php
change this:

  if ($pages_listing->RecordCount() > 1 and EZPAGES_SHOW_TABLE_CONTENTS == '1') {?>
 <div id="navEZPagesTOCWrapper">
 <h2 id="ezPagesTOCHeading"><?php echo TEXT_EZ_PAGES_TABLE_CONTEXT; ?></h2>
 <div id="navEZPagesTOC">
 <ul>
<?php while (!$pages_listing->EOF) {
 // could be used to change classes on current link and toc (table of contents) links
      if ($pages_listing->fields['pages_id'] == $_GET['id']) { ?>
 
<li><?php echo CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($pages_listing->fields['pages_id']);?>"><?php echo $pages_listing->fields['pages_title']; ?></a></li>
 
 <?php } else { ?>
 
<li><?php echo NOT_CURRENT_PAGE_INDICATOR; ?><a href="<?php echo  zen_ez_pages_link($pages_listing->fields['pages_id']); ?>"><?php echo $pages_listing->fields['pages_title']; ?></a></li>
 <?php
       }
      $pages_listing->MoveNext();
     } ?>
 </ul>

to this:

  if (sizeof($toc_links) > 1 and EZPAGES_SHOW_TABLE_CONTENTS == '1') {?>
 <div id="navEZPagesTOCWrapper">
 <h2 id="ezPagesTOCHeading"><?php echo TEXT_EZ_PAGES_TABLE_CONTEXT; ?></h2>
 <div id="navEZPagesTOC">
 <ul>
<?php foreach($toc_links as $link) {
 // could be used to change classes on current link and toc (table of contents) links
      if ($link['pages_id'] == $_GET['id']) { ?>
 
<li><?php echo CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($link['pages_id']);?>"><?php echo $link['pages_title']; ?></a></li>
 
 <?php } else { ?>
 
<li><?php echo NOT_CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($link['pages_id']); ?>"><?php echo $link['pages_title']; ?></a></li>
 <?php
       }
     } ?>
 </ul>

[wilt]

Hi Wilt

sorry...brain fade on that one...just to confirm, then, my legacy site has NO query cache installed....the current live site DOES. Both had the same ToC problem. Apologies....

No Probs. Thanks for the clarification

[laurelsstitchery]

DrByte - I upgraded to 1.5.1 last night and discovered my TOC for a set of EZ-pages wasn't working this morning. I implemented the changes you detailed below and it's working again. Thanks! :)

I'd like to test what I think is an improvement to the code overall:

/includes/modules/pages/page/header_php.php
change the following:

$pages_listing = $db->execute($pages_order_query);

 while (!$pages_ordering->EOF) {
   $vert_links[] = $pages_ordering->fields['pages_id'];
   $pages_ordering->MoveNext();
 }

to this instead (changing one line, adding another line):

$toc_links = array();


 while (!$pages_ordering->EOF) {
   $vert_links[] = $pages_ordering->fields['pages_id'];
   $toc_links[] = array('pages_id' => $pages_ordering->fields['pages_id'], 'pages_title' => $pages_ordering->fields['pages_title']);
  $pages_ordering->MoveNext();
 }

And also for /includes/templates/YOUR_TEMPLATE_NAME_HERE/templates/tpl_page_default.php
change this:

  if ($pages_listing->RecordCount() > 1 and EZPAGES_SHOW_TABLE_CONTENTS == '1') {?>
 <div id="navEZPagesTOCWrapper">
 <h2 id="ezPagesTOCHeading"><?php echo TEXT_EZ_PAGES_TABLE_CONTEXT; ?></h2>
 <div id="navEZPagesTOC">
 <ul>
<?php while (!$pages_listing->EOF) {
 // could be used to change classes on current link and toc (table of contents) links
      if ($pages_listing->fields['pages_id'] == $_GET['id']) { ?>
 
<li><?php echo CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($pages_listing->fields['pages_id']);?>"><?php echo $pages_listing->fields['pages_title']; ?></a></li>
 
 <?php } else { ?>
 
<li><?php echo NOT_CURRENT_PAGE_INDICATOR; ?><a href="<?php echo  zen_ez_pages_link($pages_listing->fields['pages_id']); ?>"><?php echo $pages_listing->fields['pages_title']; ?></a></li>
 <?php
       }
      $pages_listing->MoveNext();
     } ?>
 </ul>

to this:

  if (sizeof($toc_links) > 1 and EZPAGES_SHOW_TABLE_CONTENTS == '1') {?>
 <div id="navEZPagesTOCWrapper">
 <h2 id="ezPagesTOCHeading"><?php echo TEXT_EZ_PAGES_TABLE_CONTEXT; ?></h2>
 <div id="navEZPagesTOC">
 <ul>
<?php foreach($toc_links as $link) {
 // could be used to change classes on current link and toc (table of contents) links
      if ($link['pages_id'] == $_GET['id']) { ?>
 
<li><?php echo CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($link['pages_id']);?>"><?php echo $link['pages_title']; ?></a></li>
 
 <?php } else { ?>
 
<li><?php echo NOT_CURRENT_PAGE_INDICATOR; ?><a href="<?php echo zen_ez_pages_link($link['pages_id']); ?>"><?php echo $link['pages_title']; ?></a></li>
 <?php
       }
     } ?>
 </ul>

[DrByte]

Thanks for confirming.

[wilt]

Hi,

Note. Fix has been committed

Please see https://github.com/zencart/zencart/c...e1f6d3b9cf2f85

[enzo-ita]

Had the same problem,
found this thread and fixed.
I can confirm it works either.
ZC 1.5.1. Italian version.
Ciao from Italy. enzo