[Fixed 1.6.0] template_filename not selecting in functions_email.php

[carlvt88]

In functions_email.php, the function zen_build_html_email_from_template() refers to a $current_page_base. In dubugging, this was always null. I changed line 427 to use $module instead of $current_page_base:

    $template_filename = DIR_FS_EMAIL_TEMPLATES . $langfolder . "email_template_" . $module . ".html";

[DrByte]

$current_page_base. In dubugging, this was always null.

Not sure what exactly you're debugging.

$current_page_base is not null. In fact it's used 267 times.

[carlvt88]

(sorry if this is a resend)

In testing, I wasn't seeing the order_status email template used. Status changes always sent the default template.

This is on my development system, Win7 / xampp 3.0.12 / netbeans 7.2.

I set a breakpoint in functions_email.php line 427. This is where the template_filename is constructed from, among other things, $current_page_base. When I single stepped to this point, $current_page_base was null, so I used $module instead which evaluated to "order_status" - constructing the correct $template_filename.

[DrByte]

Oh. This is on the *admin* side?

[carlvt88]

correct

[DrByte]

Aha. Okay, try this change instead. Add the line to the top of the function, as shown:

    global $messageStack, $current_page_base;
    if (NULL == $current_page_base) $current_page_base = $module;

[carlvt88]

OK - Thanks!

[DrByte]

The fix will be included in v1.6.0: https://github.com/zencart/zencart/c...ef462da0ba56b8