I tried using the code from the git repo on a test site, togetheer with a slightly adjusted payment module fee.
Here's what I have found and remembered to write down:
When using an account where the user is in another country and using a European Tax number, if I try to checkout, store pickup and pay using paypal (this is where the extra fee comes into play), then the taxes calculated do include the taxes over the paypal fee. These taxes are included in the total price.
If I use some of the old code from this mod, where there is an adjustment made to /includes/functions/functions_taxes.php, then the unwanted taxes that were calculated over the paypal fee are no longer included in the total price.
When having an address in Belgium, no VAT number, then there were no taxes calculated. Added in /includes/functions/extra_functions/functions_vatmod.php at the last part of the file
changed:
Code:
if ($tva_intracom->fields['country_id'] === $store_country->fields['store_country']) {
return false;
} else {
return true;
}
to:
Code:
if ($tva_intracom->fields['country_id'] === $store_country->fields['store_country']) {
return false;
} elseif ($tva_intracom->fields['tva_intracom'] === '') {
return false;
} else {
return true;
}
I think that's the changes I have had to make, and so far it's looking good.
I'm glad someone is still working on this mod.
Bookmarks