Results 1 to 2 of 2
  1. #1
    Join Date
    Feb 2009
    Location
    UK
    Posts
    1,221
    Plugin Contributions
    1

    Default [Not a bug] Database column named incorrectly?

    Looking in the database to get get a handle on how Zen Cart uses the product attribute information, it struck me that

    in table 'products_attributes' the column

    'products_options_sort_order'
    should be
    'products_options_values_sort_order'

    as is the case in table 'products_options_values'

    There may be a good reason for this, but it caused me a lot of confusion (not difficult!) until I realised what this column actually contained.

  2. #2
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Database column named incorrectly?

    Good eye.

    but ...

    Not a bug.

    While the name is less descriptive than what it could be, it is used consistently throughout the code, which means it functions correctly, so it's not technically a bug.

    The name was inherited from oscommerce in 2003.
    Indeed they could have chosen a name which more accurately reflects that field's purpose.


    Strictly speaking, it could have been called "fred" and still work as long as it was called "fred" everywhere in the PHP code which uses it.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. Named Anchors Not Working?
    By tracstev in forum General Questions
    Replies: 13
    Last Post: 16 Feb 2011, 07:12 AM
  2. Replies: 3
    Last Post: 9 Nov 2010, 01:29 PM
  3. [Not a bug] Coupons not deleted from database
    By Steven300 in forum Bug Reports
    Replies: 2
    Last Post: 29 Apr 2009, 12:15 AM
  4. [Not a Bug] Logging :: Store Database Queries
    By shrimp-gumbo-mmmhhh in forum Bug Reports
    Replies: 4
    Last Post: 14 Aug 2008, 06:06 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR