Testimonial Manager Support Thread (for ZC v1.5.x)

[DivaVocals]

you notify them by making the necessary changes, and submit an updated version

So I assume this all can be deleted as it is not supposed to be here?

INSERT INTO `configuration` VALUES (NULL, 'Product option type Select', 'PRODUCTS_OPTIONS_TYPE_SELECT', '0', 'The number representing the Select type of product option.', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Upload prefix', 'UPLOAD_PREFIX', 'upload_', 'Prefix used to differentiate between upload options and other options', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Text prefix', 'TEXT_PREFIX', 'txt_', 'Prefix used to differentiate between text option values and other option values', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Image Handler Version', 'IH_VERSION', '2.0', 'This is used by image handler to check if the database is up to date with uploaded image handler files.', 0, 100, NULL, now(), NULL, 'zen_cfg_textarea_small(');

I went back to the plugins section and downloaded a fresh copy of the v1.5.4. Checking the uninstall.sql, the same 4 inserts were present. I then figured I would check other uploaded versions. I downloaded the latest v1.5.5 and 2 other older versions v1.5.3d and v 1.5.2. To my surprise, ALL of them have these same 4 inserts.

To help others who may do a uninstall how do I notify the zencart team that the uploaded uninstall.sql needs to be changed?

[mc12345678]

So I assume this all can be deleted as it is not supposed to be here?

INSERT INTO `configuration` VALUES (NULL, 'Product option type Select', 'PRODUCTS_OPTIONS_TYPE_SELECT', '0', 'The number representing the Select type of product option.', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Upload prefix', 'UPLOAD_PREFIX', 'upload_', 'Prefix used to differentiate between upload options and other options', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Text prefix', 'TEXT_PREFIX', 'txt_', 'Prefix used to differentiate between text option values and other option values', 0, NULL, NULL, now(), NULL, NULL);
INSERT INTO `configuration` VALUES (NULL, 'Image Handler Version', 'IH_VERSION', '2.0', 'This is used by image handler to check if the database is up to date with uploaded image handler files.', 0, 100, NULL, now(), NULL, 'zen_cfg_textarea_small(');

I went back to the plugins section and downloaded a fresh copy of the v1.5.4. Checking the uninstall.sql, the same 4 inserts were present. I then figured I would check other uploaded versions. I downloaded the latest v1.5.5 and 2 other older versions v1.5.3d and v 1.5.2. To my surprise, ALL of them have these same 4 inserts.

To help others who may do a uninstall how do I notify the zencart team that the uploaded uninstall.sql needs to be changed?

The extra inserts resolve a potential problem of running the uninstall as it currently is programmmed. If on uninstall the 'Testimonials Manager' group is not found, then the configuration_id will be set to zero. Then when the delete is run, those values will be removed. (IH4 also installs at that location.) Ideally the deletions would include a statement in the WHERE clause that the configuration_id (or if I used the wrong spelling.) !=0

This is something that has been reported as a potential issue. Again though the fix was to restore the four known items that could get deleted, rather than prevent the deletion in the first place.

In regards to "letting the ZC Team" know about an update, well, easy to do. Make the changes, then upload the change to the forum, explain in the documentation why the change was made, how to install it, what file(s) changed, etc... And the ZC staff will be notified to activate the change, which will happen after a review.

[DivaVocals]

Well how about this.. those extra inserts are the WRONG SOLUTION to the problem.. the RIGHT SOLUTION is to FIX the uninstall SQL..

The extra inserts resolve a potential problem of running the uninstall as it currently is programmmed. If on uninstall the 'Testimonials Manager' group is not found, then the configuration_id will be set to zero. Then when the delete is run, those values will be removed. (IH4 also installs at that location.) Ideally the deletions would include a statement in the WHERE clause that the configuration_id (or if I used the wrong spelling.) !=0

This is something that has been reported as a potential issue. Again though the fix was to restore the four known items that could get deleted, rather than prevent the deletion in the first place.

In regards to "letting the ZC Team" know about an update, well, easy to do. Make the changes, then upload the change to the forum, explain in the documentation why the change was made, how to install it, what file(s) changed, etc... And the ZC staff will be notified to activate the change, which will happen after a review.

[Ajeh]

You do not want to remove these configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Those are important to leave in your configuration table as they are used by Zen Cart, regardless of your add-ons ...

[mc12345678]

Well how about this.. those extra inserts are the WRONG SOLUTION to the problem.. the RIGHT SOLUTION is to FIX the uninstall SQL..

You do not want to remove these configuration_keys:
PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX

Those are important to leave in your configuration table as they are used by Zen Cart, regardless of your add-ons ...

*nodding in agreement* correctly repairing the uninstall.sql so that only data specifically associated with the install is deleted/modified, which means not to remove the three ZC default values and the one that is added by another plugin.

Just deleting the four inserts will not fully resolve the situation.

[DivaVocals]

*nodding in agreement* correctly repairing the uninstall.sql so that only data specifically associated with the install is deleted/modified, which means not to remove the three ZC default values and the one that is added by another plugin.

Just deleting the four inserts will not fully resolve the situation.

and the actual solution is SOOOOOO simple.. Remove the 4 extra insert statements (it was NEVER the right solution..) then just remove this line:

SET @configuration_group_id=0;

and you are left with the RIGHT uninstall script..

#Testimonials Manager SQL Uninstall

SELECT @configuration_group_id:= `configuration_group_id`
FROM configuration_group
WHERE configuration_group_title= 'Testimonials Manager'
LIMIT 1;

DELETE FROM configuration WHERE configuration_group_id = @configuration_group_id;
DELETE FROM configuration_group WHERE configuration_group_id = @configuration_group_id;
DELETE FROM configuration WHERE configuration_key = 'DEFINE_TESTIMONIAL_STATUS';

DROP TABLE IF EXISTS `testimonials_manager`;

DELETE FROM admin_pages WHERE page_key = 'configTestimonialsManager' LIMIT 1;
DELETE FROM admin_pages WHERE page_key = 'TestimonialsManager' LIMIT 1;

Now if anyone wants to "notify the admin" by updating the package and submitting an update.. feel free..

[lat9]

and the actual solution is SOOOOOO simple.. Remove the 4 extra insert statements (it was NEVER the right solution..) then just remove this line:

SET @configuration_group_id=0;

and you are left with the RIGHT uninstall script..

#Testimonials Manager SQL Uninstall

SELECT @configuration_group_id:= `configuration_group_id`
FROM configuration_group
WHERE configuration_group_title= 'Testimonials Manager'
LIMIT 1;

DELETE FROM configuration WHERE configuration_group_id = @configuration_group_id AND @configuration_group_id != 0;
DELETE FROM configuration_group WHERE configuration_group_id = @configuration_group_id AND @configuration_group_id != 0;
DELETE FROM configuration WHERE configuration_key = 'DEFINE_TESTIMONIAL_STATUS';

DROP TABLE IF EXISTS `testimonials_manager`;

DELETE FROM admin_pages WHERE page_key = 'configTestimonialsManager' LIMIT 1;
DELETE FROM admin_pages WHERE page_key = 'TestimonialsManager' LIMIT 1;

Now if anyone wants to "notify the admin" by updating the package and submitting an update.. feel free..

Just a couple of minor updates, shown in red above.

[DivaVocals]

Just a couple of minor updates, shown in red above.

HA! Good catch!!

[mc12345678]

HA! Good catch!!

Yup.

Just a little explanation for those that may like to understand more:
That additional code will categorically prevent the need for the four inserts that were a part of the previous uninstall.sql and will prevent the deletion of the three values pointed out by ajeh.

As previously written if the @configuration_group_id wasn't present for the searched title, then it was possible that the return value would be 0, and the subsequent delete's would delete items having a value of 0 (at least the three identified by ajeh, and as well one value from the IH4 install and any other modified code that chose to use a configuration_group_id of 0) which would end up causing problems for the store if the first three were deleted.

[DollyDuke]

I have this installed and i got a Install Success but it is not showing in the Layout Box Controller so I cant turn it on so it is not showing up on my site...any help would be welcome.