Results 1 to 4 of 4
  1. #1
    Join Date
    Dec 2009
    Location
    Amersfoort, The Netherlands
    Posts
    2,846
    Plugin Contributions
    25

    Default coupon_admin.php contains double p tag

    I am not sure in which version this started, but in Zen Cart 1.5.1 the language file coupon_admin.php (location: admin/includes/language/english/),contains two defines with a double <p> tag (line 51 and 52)

    PHP Code:
    define('TEXT_COUPON_HELP_DATE''<p><p>The coupon is valid between %s and %s</p></p>');
    define('HTML_COUPON_HELP_DATE''<p><p>The coupon is valid between %s and %s</p></p>'); 
    This should be
    PHP Code:
    define('TEXT_COUPON_HELP_DATE''<p>The coupon is valid between %s and %s</p>');
    define('HTML_COUPON_HELP_DATE''<p>The coupon is valid between %s and %s</p>'); 

  2. #2
    Join Date
    Oct 2012
    Posts
    49
    Plugin Contributions
    0

    Default Re: coupon_admin.php contains double p tag

    Found it in 1.5 - does it make any difference to remove or not?

  3. #3
    Join Date
    Dec 2009
    Location
    Amersfoort, The Netherlands
    Posts
    2,846
    Plugin Contributions
    25

    Default Re: coupon_admin.php contains double p tag

    You should remove it, it gives validation errors, and could cause unwanted behaviour/errors on the pages

  4. #4
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: coupon_admin.php contains double p tag

    In practice it's harmless. It won't break anything.

    The duplication will be removed in a future version.

    But if you're asking whether it's something you should lose sleep over, it's not. It's like the lowest level of urgency.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. v150 [duplicate] myDEBUG coupon_admin.php
    By ray-the-otter in forum Bug Reports
    Replies: 3
    Last Post: 2 Jul 2013, 10:47 AM
  2. category list contains a html break tag
    By tomk in forum Basic Configuration
    Replies: 4
    Last Post: 30 Nov 2011, 09:40 PM
  3. Suspecion in admin/coupon_admin.php
    By TheOracle in forum General Questions
    Replies: 4
    Last Post: 31 Jul 2006, 02:57 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR