[Done v1.5.5] PHP 5.4 warnings: Illegal string offset

[Woodymon]

Assuming there were no other code change dependencies in play,
I tested the new code in the two github links posted above on a a ZC 1.51 shop:

1. RE: https://github.com/zencart/zencart/c...2cb78fc86946c9

Tested the code changes in twelve files on above github page

After editing the twelve files, added virtual download products to shopping cart, then clicked "Go to Checkout", then observed the following error:

https://domainname/shop/index.php?ma...ckout_shipping

Error in Firefox: "The page isn't redirecting properly. Firefox has detected that the server is redirecting the request for this address in a way that will never complete. This problem can sometimes be caused by disabling or refusing to accept cookies."

I ensured Firefox was not blocking cookies, and indeed, checking out with download products in the cart worked before updating the twelve files. I observe the same result in IE.

Had no issue checking out with physical products.

2. In regards to the file update for tpl_checkout_shipping_default.php

The github change code for the above file shows "$checked = FALSE;" as a pre-existing line of code.

// set the radio button to be checked if it is the method chosen
$checked = FALSE;

however, this line does not already appear in the zc 1.51 stock file.

And yet github does not show the line of code "$checked = FALSE;" as new
(not displayed in green with a "+" symbol) indicating it should be added.

I went ahead added that code line.


3. Re: https://github.com/zencart/zencart/c...6deb80026d2886

Employed the code changes in /includes/functions/sessions.php

Following that, I observed the sessionid (zenid) was no longer appended to the shop URL while navigating through the shop (and user tracking mod logs showed the same).

Observed no related error or warnings in either the server error log or zc logs.

Reverting to the stock sessions.php, zenid was again employed.