[Done v1.6.0] CHARSET and charsetClean (potential bug?)

[paulm]

Maybe not a bug as such, because it looks like this function is not currently used by the Zen Cart core or any other code. I just happened to notice it when I was checking how Zen Cart handles encoding.

But this function (in includes/functions/functions_general.php)

  function charsetClean($string) {
    if (CHARSET == 'UTF-8') return $string;
    if (function_exists('iconv')) $string = iconv("Windows-1252", CHARSET . "//IGNORE", $string);
    $string = htmlentities($string, ENT_QUOTES, 'UTF-8');
    $string = html_entity_decode($string, ENT_QUOTES, CHARSET);
    return $string;
  }

Won't work as intended because the default CHARSET setting in Zen Cart is defined in english.php as utf-8, not UTF-8. So the if (CHARSET == 'UTF-8') line will never be true (unless someone changes the CHARSET setting to UTF-8).

Not sure if this function will ever be used, or that it's just some legacy code or something.

[DrByte]

Yes it is a bug.

No it does not affect anything, since that function is not used in core code at the present time.

Thanks for pointing it out.

Something like this would be better:

    if (preg_replace('/[^a-z0-9]/', '', strtolower(CHARSET)) == 'utf8') return $string;

[paulm]

Thanks for the reply.

And your suggestion looks good, I will use it for the Twitter sidebox add on