Results 1 to 2 of 2
  1. #1
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,595
    Plugin Contributions
    30

    Default [Done v1.6.0] extraction of $sort_order in default_filter.php

    Line 115 (in red)
    // if set to nothing use products_sort_order and PRODUCTS_LIST_NAME is off
    if (PRODUCT_LISTING_DEFAULT_SORT_ORDER == '') {
    $_GET['sort'] = '20a';
    }
    } else {
    $sort_col = substr($_GET['sort'], 0 , 1);
    $sort_order = substr($_GET['sort'], 1);
    switch ($column_list[$sort_col-1]) {
    This will extract all the chars after the first one, rather than just the last one. While it will work with a two character sort code, maybe it needs to be corrected in light of this:
    http://www.zen-cart.com/showthread.p...ulty-iteration

    Suggest
    $sort_order = substr($_GET['sort'], -1, 1);
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto...

  2. #2
    Join Date
    Jan 2004
    Posts
    66,380
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: [Done v1.6.0] extraction of $sort_order in default_filter.php

    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. Replies: 14
    Last Post: 22 May 2013, 04:00 AM
  2. $box_categories_array[i]['sort_order'] ?
    By scatzc in forum General Questions
    Replies: 15
    Last Post: 24 Aug 2010, 09:44 PM
  3. Need SQL syntax for Product Extraction
    By shocker in forum General Questions
    Replies: 0
    Last Post: 15 Feb 2009, 11:56 AM
  4. sort_order in Configuration table insert
    By torvista in forum Built-in Shipping and Payment Modules
    Replies: 5
    Last Post: 18 Oct 2008, 07:54 PM
  5. [done 1.3.7] default_filter.php bug
    By cees in forum Bug Reports
    Replies: 6
    Last Post: 31 Jan 2007, 04:37 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR