Support Thread: Report All Errors (Even Warnings)

[DrByte]

Probably need to apply this && to & fix: https://github.com/zencart/zencart/pull/1144/files

[lat9]

Thanks, DrByte! I've incorporated those changes and uploaded v2.0.3 of Report All Errors to the plugins.

[Website Rob]

With && fix applied, there are still PHP Notices being shown when using the module.

I guess I misunderstood about Notices being disabled as I can see in Configuration -> Logging it states:
Do you want create debug-log files for all PHP errors, even warnings,

Perhaps disabling Notices can be a feature in a future version?

[lat9]

With && fix applied, there are still PHP Notices being shown when using the module.

I guess I misunderstood about Notices being disabled as I can see in Configuration -> Logging it states:
Do you want create debug-log files for all PHP errors, even warnings,

Perhaps disabling Notices can be a feature in a future version?

With the change, notices should (by default) not be logged when Report All Errors is disabled, with only Error and Warning type issues being logged. The (even warnings) addition in the plugin's name should, thus, just be ignored.

[Website Rob]

I can confirm that when All Errors features are disabled, no PHP Notices are recorded / shown when the fix mentioned earlier by Dr. Byte has been applied.

If you want the module other features they need to be manually enabled.

Admin -> Configuration -> Logging
Report All Errors (Admin)?
Report All Errors (Store)?
Report All Errors: Backtrace on Notice Errors?

And that is when PHP Notices will also be recorded / shown.


In continued testing I noticed something not mentioned in the module documentation. In v2.0.2 (v2.0.3 is not available as of today's date) I did not read anywhere that the module is enabled by default and will record / display only error(s). That was a pleasant surprize and exactly what I was looking for.

Also, I know at one time it was possible for PHP to also state at what character in the line the error found. Not sure if that is possible anymore but be nice to have again.

[lat9]

v2.0.3 is now available for download from the Plugins area.

[Lordzoabar]

Not sure if I missed it in the thread or not, but when I installed it, both my admin and live site were replaced with a page listing all the errors. Decent little heart attack there, until I disabled the actual php files (just added ~ at the end of them all), but I did save the generated log. Came back with close to 1000 undefined and already defined index and constants, plus a smattering of others. I saw the notice about the already defined ones, but what about all the undefined? My site WORKS... but that's still a LOT of errors that came up...

[lat9]

Not sure if I missed it in the thread or not, but when I installed it, both my admin and live site were replaced with a page listing all the errors. Decent little heart attack there, until I disabled the actual php files (just added ~ at the end of them all), but I did save the generated log. Came back with close to 1000 undefined and already defined index and constants, plus a smattering of others. I saw the notice about the already defined ones, but what about all the undefined? My site WORKS... but that's still a LOT of errors that came up...

What version of Zen Cart and PHP are you using?

Report All Errors does, as you indicated, have a setting to "not report" those already-defined constants. Those issues are normally due to the way that Zen Cart handles cascading language files, e.g. the file /includes/languages/english.php gets loaded in addition to /includes/languages/YOUR_TEMPLATE/english.php. Those reports do not pose any current issue.

The reports of undefined constants are, however, of concern. PHP 7.2's release indicates that the use of undefined constants is deprecated, and will result in an error in a future PHP version. That said, I'd focus my inspection on those reports!

[Lordzoabar]

What version of Zen Cart and PHP are you using?

Zen Cart 1.5.5d, and PHP 5.4.45

I've broken down the main log file, into multiple, individual files based on which php file is in question, but the website has been around longer than I have been with the company, so there is a lot of stuff to shift through, and (unfortunately) there was never a "sandbox" version of the store set up to safely test any fixes in.

[lat9]

Any reason the store is still on that oldy-moldy version of PHP?

Creating a sandbox site is pretty easy; if you're interested, please start a new forum thread so we don't muddy-up this plugin's support thread.