Orders Status History -- Updated By [Support Thread]

[DigitalShadow]

if i don't change anything and just update the order, a new record is also generated in TABLE_ORDER_STATUS_HISTORY

this is what my TABLE_ORDER_STATUS_HISTORY structure is

1 orders_status_history_id
2 orders_id
3 orders_status_id
4 date_added
5 customer_notified
6 comments
7 comment_by
8 track_id1
9 track_id2
10 track_id3
11 track_id4
12 track_id5
13 track_id6
14 rma_number
15 action
16 updated_by

[DigitalShadow]

i put that, there is no log file in logs

would you like a copy of my orders.php file to see if any other mods are breaking your calls?

[lat9]

i put that, there is no log file in logs

would you like a copy of my orders.php file to see if any other mods are breaking your calls?

Sure. Since there's no debug-log, the function isn't being called -- that's why there's no updated_by value!

[DigitalShadow]

that is what i assumed, pm sent

[lat9]

I've just uploaded v1.2.1 to the Plugins. It contains the correction to properly handle CR/LF sequences in the status-update messages.

[ShopVille]

Thanks for this great mod!
I followed the readme and was able to install it successfully, the updated by column is also being updated as it should, however when i do an update i get a 500 server error (the update is actually done but its not redirecting to the order page as it should) I suspect that this is caused by some error when merging the orders.php file, if I upload my orders.php file could someone take a moment to review the issue?

TIA

[ShopVille]

Thanks for this great mod!
I followed the readme and was able to install it successfully, the updated by column is also being updated as it should, however when i do an update i get a 500 server error (the update is actually done but its not redirecting to the order page as it should) I suspect that this is caused by some error when merging the orders.php file, if I upload my orders.php file could someone take a moment to review the issue?

TIA

Update:

When I removed the following text marked in bold red from orders.php the 500 server error disappeared however the updated by column would no longer update:

// BEGIN TY TRACKER 1 - DEFINE VALUES ----------------------------------------------
        $track_id1 = str_replace(" ", "", zen_db_prepare_input($_POST['track_id1']));
        $track_id2 = str_replace(" ", "", zen_db_prepare_input($_POST['track_id2']));
        $track_id3 = str_replace(" ", "", zen_db_prepare_input($_POST['track_id3']));
        $track_id4 = str_replace(" ", "", zen_db_prepare_input($_POST['track_id4']));
        $track_id5 = str_replace(" ", "", zen_db_prepare_input($_POST['track_id5']));
// END TY TRACKER 1 - DEFINE VALUES ------------------------------------------------------------------

      
//-bof-c-snap_affiliates-v2.5.0
/* ----- Processing now handled by separate function -----
        $order_updated = false;
// BEGIN TY TRACKER 2 - INCLUDE DATABASE FIELDS IN STATUS QUERY ----------------------------------------------
        $check_status = $db->Execute("SELECT customers_name, customers_email_address, orders_status, payment_module_code, shipping_module_code,
				      date_purchased from " . TABLE_ORDERS . "

And

*/
  $check_status = $db->Execute("SELECT orders_status, date_purchased FROM " . TABLE_ORDERS . " WHERE orders_id = '" . (int)$oID . "'");
        $customer_notified = (isset($_POST['notify']) && ($_POST['notify'] == 1 || $_POST['notify'] == -1)) ? $_POST['notify'] : 0;
        $osh_record_added = zen_update_orders_history($oID, $comments, null, $status, $customer_notified, (isset($_POST['notify_comments']) && $_POST['notify_comments'] == 'on'));
        $order_updated = ($osh_record_added == -1) ? false : true;

//-eof-c-snap_affiliates-v2.5.0

[lat9]

@ShopVille, that implies to me that the merge into /YOUR_ADMIN/orders.php missed something. If you send me a copy of your orders.php file via PM, I'll give it a look.

What version of Zen Cart? What other plugins have you installed that muck with orders.php?

[lat9]

I've just submitted v1.3.0 to the plugins for review.

Updates the plugin for Zen Cart v1.5.5 compatibility and to allow the common update function to properly operate when issued from either the admin-console or the storefront.

[lat9]

v1.3.0 is now available for download.