Results 1 to 2 of 2
  1. #1
    Join Date
    Sep 2004
    Location
    Western Massachusetts
    Posts
    2,945
    Plugin Contributions
    5

    Default [Done 1.5.3] Paypal Status Check - incorrect nesting of condition check

    In includes/modules/payment/paypaldp.php - for the function update_status()...

    The condition checks for order amount exceeding 10,000 or order total = 0 (starting at line 231) are currently nested inside the check for the payment zone at line 205:

    Code:
    if ($this->enabled && (int)$this->zone > 0 && isset($order->billing['country']['id']))
    The resulting effect of this is that if there is no payment zone set for the module (ie: MODULE_PAYMENT_PAYPALDP_ZONE = 0), these order amount condition checks are completely bypassed.

    Shouldn't these two order amount condition checks be moved outside the zone check at line 205?

    (I also checked the fileset for v1.5.2-RC2 - issue is the same there)
    Neville
    An assumption is what you arrive at when you get tired of thinking...

  2. #2
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Paypal Status Check - incorrect nesting of condition check

    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. Replies: 3
    Last Post: 31 Jul 2016, 04:46 PM
  2. 139 paypal express check out final check out page "blank"
    By imen in forum PayPal Express Checkout support
    Replies: 8
    Last Post: 31 Dec 2013, 04:57 PM
  3. What do I edit to remove Check from Check/Money Order payment?
    By GroovyThreads in forum Built-in Shipping and Payment Modules
    Replies: 1
    Last Post: 10 Jan 2009, 03:11 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR