Page 1 of 4 123 ... LastLast
Results 1 to 10 of 35
  1. #1
    Join Date
    Jun 2003
    Location
    Newcastle UK
    Posts
    2,896
    Blog Entries
    2
    Plugin Contributions
    2

    Default Github Collaboration

    Hi.

    We have been making some changes to our github account in relation to how people can contribute to core code, as well as adding some stuff to make it easier to set up a development environment for v160.

    To get started, see http://docs.zen-cart.com/Contributing/main

    For the development environment see the Habitat repostitory and associated help pages
    For the main v160 development, we are in the process of moving our internal issues, that we previously tracked with JIRA, directly on to github.

    We have also created a Contributors team on Github that consists of people who have previously contributed pull requests to the github v160 branch.

    Creating this team allows us to assign tasks to people in the Contributors team.
    If you want to be part of this team, you need to:
    1. create a github account
    2. fork the zencart/zencart repository
    3. PM a founder for them to activate your github team account, and include the link to your forked repository
    4. When pm'ing a founder, it would help if you could give some detail about what areas of code you could help with

    PM Links
    DrByte http://www.zen-cart.com/private.php?do=newpm&u=6
    wilt http://www.zen-cart.com/private.php?do=newpm&u=2
    Last edited by wilt; 9 Jul 2014 at 08:36 PM.

  2. #2
    Join Date
    Feb 2005
    Location
    Italy
    Posts
    199
    Plugin Contributions
    0

    Default Re: Github Collaboration

    Hello, I had some problems to have habitat working on a win 7 machine. Here they are and how I solved them:

    1) I already have mysql installed on my win 7, with the default port 3306. But running vagrant up says that there is a conflict over the port 3306, because habitat uses the same port.

    The solution is to forward the port for mysql (for the vm we're installing) to another port. I used 33306.
    To make this, go to habitat.rb in your habitat folder, near line 25 you find config.vm.network "forwarded_port", guest: 3306, host: 3306 just change the second value to 33306 (or any other value not conflicting).

    2) After that I was able to access mysql via ssh (hmmm using putty, not yet simply typing vagrant ssh) and was able to access zen.local via browser but it was empty. Looking at the messages after vagrant up I understood that ssh commands were not executed, so, after a bit of google, I found that even if I had a ssh client installed, it was not available in my habitat folder. So the solution was to add the path to my ssh client exe to the path.

    3) After that I run again vagrant provision, but new errors came up: something like \r command not found referred to line, line 8 etc... of serve.sh So I just opened serve.sh and changed the line endings from windows to Unix.

    This solved everything and after another provisioning, it started syncing with Github (now I just have to remove everything again and try to provision the machine using my keys for Github).

    Hope this may help others with similar issues :)
    Last edited by DrByte; 19 Sep 2014 at 08:02 PM. Reason: fixed a typo in the port-forwarding instructions
    Paolo De Dionigi
    Co-maintainer of Zen Cart Italia

  3. #3
    Join Date
    Jun 2003
    Location
    Newcastle UK
    Posts
    2,896
    Blog Entries
    2
    Plugin Contributions
    2

    Default Re: Github Collaboration

    Hi

    Thanks for the post. It probably makes sense to allow for defining of some of the port forwards. We are working on some updates habitat and will build that into it.

  4. #4
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Github Collaboration

    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #5
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,586
    Plugin Contributions
    30

    Default Re: Github Collaboration

    I find the Github->New Issues->Submit button is not available/grayed/greened-out:

    Name:  github_submit_greyed_out.gif
Views: 901
Size:  3.0 KB
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto...

  6. #6
    Join Date
    Jul 2012
    Posts
    16,732
    Plugin Contributions
    17

    Default Re: Github Collaboration

    Quote Originally Posted by torvista View Post
    I find the Github->New Issues->Submit button is not available/grayed/greened-out:

    Name:  github_submit_greyed_out.gif
Views: 901
Size:  3.0 KB
    Are you logged in?
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  7. #7
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,586
    Plugin Contributions
    30

    Default Re: Github Collaboration

    Are you logged in?
    Yes...link to my profile is active
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto...

  8. #8
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,688
    Plugin Contributions
    9

    Default Re: Github Collaboration

    are you sure you are on the right repository?

    https://github.com/zencart/zencart/issues/new
    author of square Webpay.
    mxWorks has premium plugins. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  9. #9
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,586
    Plugin Contributions
    30

    Default Re: Github Collaboration

    are you sure you are on the right repository?
    Yes...I tried again with your link...and have just spotted that if you don't put a title...the Submit does not work...and does not flag the error!

    So, I'll put that down to bad form design, it couldn't be user error!
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto...

  10. #10
    Join Date
    Jul 2012
    Posts
    16,732
    Plugin Contributions
    17

    Default Re: Github Collaboration

    Quote Originally Posted by torvista View Post
    Yes...I tried again with your link...and have just spotted that if you don't put a title...the Submit does not work...and does not flag the error!

    So, I'll put that down to bad form design, it couldn't be user error!
    Yeah, there's a similar problem if you edit the code from the github website and after all sorts of clicking this, typing that, if the result of your code is to end up back to where you started, no matter how much content you put into the description box, the button to commit the changes behaves the same way. Sorry for not asking further as I misunderstood the condition(s) that were plainly provided. I thought the issue was that couldn't initiate the area to fill in an issue, not that while filling in the issue information it could not be further submitted. :)
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

 

 
Page 1 of 4 123 ... LastLast

Similar Threads

  1. Zen Cart GitHub Repository
    By wilt in forum Code Collaboration
    Replies: 9
    Last Post: 30 Sep 2015, 11:27 PM
  2. v154 Putting your contributions on GitHub
    By swguy in forum Contribution-Writing Guidelines
    Replies: 0
    Last Post: 8 Feb 2015, 02:25 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR