Usps 2014 0907 k6

[jaheadlee]

I am trying to add some changes to the latest USPS (K6) to test for media mail eligibility. I added a new table that has two fields -- products_id and media_mail_eligible. I have made a number of changes in files to make this work, and it does seem to. The last change now is in usps.php -- test each item to see if its media mail eligible. If the number of items in the cart equals number of media mail items, then allow media mail. Otherwise, don't show that option.

The code isn't working, it allows media mail for everything. But more importantly it crashed Paypal integration. When clicking on PayPal option on shopping cart screen, the page goes white. The logs show this error:

                                [03-Nov-2014 19:07:26 America/Los_Angeles] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/walbur5/public_html/includes/modules/shipping/usps.php:1) in /home/walbur5/public_html/includes/modules/payment/paypalwpp.php on line 1635
[03-Nov-2014 19:07:26 America/Los_Angeles] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/walbur5/public_html/includes/modules/shipping/usps.php:1) in /home/walbur5/public_html/includes/functions/functions_general.php on line 46

If I replace my revised usps.php with the original K6, PayPal works fine -- but of course doesn't have any of my code.

The code I added replaces the example of $chk_cart for categories.

if (true) {

    error_log($_SESSION['cart']->count_contents() . ' items in cart -- ' . $type );
  $skip_media = 0;
  $chk_cart = 0;
  $chk_cart += $_SESSION['cart']->in_cart_media_check('media_mail_eligible','1'); // 1 means media mail eligible
  //if $chk)cart = the entire contents of hte cart, then media mail eligible 
  if ($chk_cart = $_SESSION['cart']->count_contents()) {

          $skip_media = 0;  // false
        } else {
        $skip_media = 1; // true
        }
        error_log($chk_cart . ' media mail eligible items -- ' . $type . 'skip_media = ' . $skip_media );
//  $chk_cart += $_SESSION['cart']->in_cart_check('master_categories_id','15');
} 

I created the new function in_cart_media_check since I don't use the products table for storing the info, but the new table. I simply changed the appropriate code to work. It seems to work (based on error_log output).

2nd code change:

if (true) {
  if ($skip_media ==  1 && $type == 'Media Mail Parcel') {

    continue;
  }
} 

I will admit I don't quite understand what the test is doing -- I simply left it from the original code, which seemed to imply that the test looked for cases where the example (Priority Mail small box) shouldn't be allowed and "continue" made that happen, but I think that must be wrong.

So there's two questions (which perhaps should be divided into two forum topics, but the code is the same for both):
1) How did I lose Paypal?
2) what is wrong with this code that it can't skip media mail when it should?

I am attaching the whole usps.php file in case something strange has been added that the above code isn't the cause of-- since the PayPal error suggests line 1. Thanks for all the help!

[Ajeh]

First check if you have a space or blank line before the starting <?php in:
/includes/modules/shipping/usps.php

[Ajeh]

NOTE: you have lots of spaces there ...

Also around line 372 you have:

  if ($chk_cart = $_SESSION['cart']->count_contents()) {

yet you are adding to $chk_cart above:

  $chk_cart += $_SESSION['cart']->in_cart_media_check('media_mail_eligible','1'); // 1 means media mail eligible

I have not tried your code, as you have database changes that I do not, but these are things that are jumping out so far ...

[jaheadlee]

NOTE: you have lots of spaces there ...

Yeah, the spaces thing has been weird. I keep getting rid of them, they keep coming back. I'll try it again. There might be something about the editor my website host puts me in that isn't compatible, although I didn't used to have this problem. Thanks!

[jaheadlee]

Well, it all seems to be working now. Paypal -- spaces were key, and they were caused by the site host's code edit capability. So, back to Notepad++ for me -- just hated to keep uploading. And the dreaded '=" vs. "==" caught me again! I flipped the check on the cart -- instead of checking to see how many items were media mail eligible, I checked to see how many weren't, and if greater than zero set the skip_media flag to 1. And all worked great. Then figured out what you were saying. Now, on to checking package weights to determine which Priority Mail box to use....

Thanks so much for your help! Sometimes it's just the simplest thing that gets us.

[Ajeh]

Trust me ... easy to spot as I've been there ... done that ... got the T-shirts ...