dist_configure.php error on logs directory path

[strelitzia]

In the dist-configure files you have

define('DIR_FS_CATALOG', '/');

//the following path is a COMPLETE path to the /logs/ folder eg: /var/www/vhost/accountname/public_html/store/logs ... and no trailing slash
define('DIR_FS_LOGS', DIR_FS_CATALOG . '/logs');

Entering the full path in 'DIR_FS_CATALOG with the trailing / creates a double slash in the logs directory path.

define('DIR_FS_LOGS', DIR_FS_CATALOG . '/logs');

should be

define('DIR_FS_LOGS', DIR_FS_CATALOG . 'logs');

[DrByte]

Thanks. We'll fix that in a future release.

But, you really should never use dist-configure.php directly. You should ALWAYS let zc_install build the correct configure.php file contents for you.

[strelitzia]

If i'm doing upgrades i don't run the installer through the steps where it builds the configure.php files though. I run zc_install just to update the database and then copy the dist-configure.php file and copy in the details from the clients original configure.php files, so in this circumstance, the error could catch the unwary out.

[DrByte]

So, you never stage your clients' upgrades in a safe place first?

[strelitzia]

Did i say that?
All upgrades are done from a clone of the clients site and database on a local server, then uploaded to the client server in a sub directory for them to test prior to go live.
Personally, i find it just as easy and probably quicker to manually edit the configure.php files as the site is moved from local, to dev, and finally to live. I've done 500+ upgrades in the same way and never once had an issue doing it this way. :)

[DrByte]

Fair enough. Just checking ;)