Has there ever been a LARGE_IMAGE_WIDTH (and _HEIGHT) constant?

[lat9]

The title pretty much says/asks it all. I'm looking at the changes to the main-image and additional-images' handling for IH4 and Zen Colorbox, both of which are quite convinced that such a constant exists; it's not there inspecting the database via phpMyAdmin.

[mc12345678]

The title pretty much says/asks it all. I'm looking at the changes to the main-image and additional-images' handling for IH4 and Zen Colorbox, both of which are quite convinced that such a constant exists; it's not there inspecting the database via phpMyAdmin.

So, ZC 1.5.1 and ZC 1.5.4 (assuming those in between as well) include LARGE_IMAGE_WIDTH in the admin/includes/modules/update_product.php file below the comment that the information is being assigned to support future image handler code...

Even in that file, $large_width and $large_height (previously assigned to the LARGE_IMAGE_WIDTH and height constants) are overwritten with values returned from getimagesize($src), so the constant is not even used in that file.

Not sure if the thought is that an image handler (perhaps not that used by IH4 or Zen Colorbox) would assign the LARGE_IMAGE_WIDTH (and height) during processing, but haven't seen anything that assigns a value to either LARGE_IMAGE_WIDTH or LARGE_IMAGE_HEIGHT.

In fact IH4 it appears that the code almost needs there not to be a defined value in order to return the original size of the image (not to resize the image). Makes me wonder about system response (using IH4 for example) if a value *is* provided... Will/could it increase the image(s) size if the size constant was assigned? Would it fail?

Overall yeah a good question, what I have seen as far as usage of the constant though is: If there were a LARGE_IMAGE_WIDTH/LARGE_IMAGE_HEIGHT constant assigned, when using the handle_image function, then that value should be sent to the handler in that area of code because one would expect to see the image at LARGE_IMAGE_WIDTH and LARGE_IMAGE_HEIGHT. As if a remnant of properly using a constant that isn't assigned awaiting the "time" when it is assigned and the system "properly" responds.

[DrByte]

The title pretty much says/asks it all. I'm looking at the changes to the main-image and additional-images' handling for IH4 and Zen Colorbox, both of which are quite convinced that such a constant exists; it's not there inspecting the database via phpMyAdmin.

I'm pretty sure there hasn't been before v160.
But in v160 the code does expect it, kinda ... although I think it needs some dependencies fixed (like constants defined): https://github.com/zencart/zencart/b...images.php#L89

But ... what's the background behind your question? Are you wanting to add them to IH?

[lat9]

I'm pretty sure there hasn't been before v160.
But in v160 the code does expect it, kinda ... although I think it needs some dependencies fixed (like constants defined): https://github.com/zencart/zencart/b...images.php#L89

But ... what's the background behind your question? Are you wanting to add them to IH?

The background is that I was looking to change the additional_images.php module for a client who's running ZC 1.5.4, noticed the use of those constants and then wondered where they were defined.