Illegal string offset 'id' in order.php

[marcopolo]

I'm getting the following error message:
Illegal string offset 'id' in order.php

Here is the line it does not like:

      if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

Server details:
Zencart 1.5.4
MySQL 5.6.24
5.6.8-1

Is this a bug?

[lat9]

A post that contains the full debug log (especially if augmented by the myDEBUG Backtrace plugin) would help. Starting in v1.5.3, the $_SESSION['shipping'] variable went through an overhaul to remove PHP warnings like you posted.

A list of your installed plugins would also be helpful.

[marcopolo]

Here is the full debug text:
[13-Jul-2015 10:08:27 America/New_York] PHP Warning: Illegal string offset 'id' in /var/www/zencart/includes/classes/order.php on line 472

[marcopolo]

Without having to list every mod is there anything I can try to fix this?

[jimmie]

ive been getting these errors on and off for a couple of years now, since installing v1.51. i dont see any real problems, i'm still making sales

[DrByte]

I'm getting the following error message:
Illegal string offset 'id' in order.php

Here is the line it does not like:

      if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

Server details:
Zencart 1.5.4
MySQL 5.6.24
5.6.8-1

Is this a bug?

Here is the full debug text:
[13-Jul-2015 10:08:27 America/New_York] PHP Warning: Illegal string offset 'id' in /var/www/zencart/includes/classes/order.php on line 472

The code you quoted is not from line 472 of ZC v1.5.4. So it appears you're using an old version of that file, or one modified by a plugin but which isn't compatible with v1.5.4

[marcopolo]

The edits are minimum and more below that line, can I send you the file to look at?

[swguy]

I believe this is still an issue. Seeing in an unmodified 1.5.4 includes/classes/order.php on line 462 with PHP 5.6.2. I can try with other PHPs if needed.

[marcopolo]

I was able to resolve the issue by changing:

if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

to

 if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && isset($_SESSION['shipping']['id']) && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

[mc12345678]

I was able to resolve the issue by changing:

if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

to

 if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && isset($_SESSION['shipping']['id']) && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

Perhaps I need to do more research, but it seems to me that this simply fixes the result of a previous problem not the problem that is causing this fix to be needed... I say this partially because I once had to apply a similar fix for a shipping module, but found out it was the shipping module that was not "generated" properly that made this issue appear...

Earlier in this thread it was asked if all modules were needed... If anything I would think those that have an effect on shipping propably would be prudent. :)