SaleMaker only discounts base price, not attributes?

[FueledByMatt]

So I was looking at a product i have on sale right now, I was expecting it to take 15% off the total of the item after all attributes were selected, but then i noticed it was only discounting the base price of the item.

is there a way to make SaleMaker apply the selected discount to the attributes as well?

I tried selecting Product Priced by Attributes, and it doesn't even apply a discount then...

Example:

https://www.fueledbymatt.com/1995200...kit-p-446.html

Selecting the level2 option, e85 option, and fuel pump using walbro 450, the total would normally be 1050.24, and 15% discount should end up with $892.70, but because it's only discounting the base price, it's coming up with $964.88

Help???

[mc12345678]

Attributes_controller for the product and looking at applicable attribute(s), what are the settings for the fourth column (is so in original ZC) that is a sort of pink button or an x... Which is it?

[FueledByMatt]

All of them are normal, not X. I've tried both ways.

i'm about to go digging through the code to find the switches for pricing and start redoing everything lol...

i doubt this has anything to do with the fact i changed salemaker to be able to create sales based on a manufacturer....that was just a simple trigger in one of the files, don't remember which...

[mc12345678]

All of them are normal, not X. I've tried both ways.

i'm about to go digging through the code to find the switches for pricing and start redoing everything lol...

i doubt this has anything to do with the fact i changed salemaker to be able to create sales based on a manufacturer....that was just a simple trigger in one of the files, don't remember which...

Might... Depending on how the database was populated as part of processing the manufacturer's sale data. Have you tried marking an item for sale using a different "indicator"? To see that it works...

[FueledByMatt]

This is the affected code:

      $sale = $db->Execute("select * from " . TABLE_SALEMAKER_SALES . " where sale_categories_all like '%," . $category . ",%' and sale_status = '1' and (sale_date_start <= now() or sale_date_start = '0001-01-01') and (sale_date_end >= now() or sale_date_end = '0001-01-01') and (sale_pricerange_from <= '" . $product_price . "' or sale_pricerange_from = '0') and (sale_pricerange_to >= '" . $product_price . "' or sale_pricerange_to = '0')");
      if ($sale->RecordCount() < 1) {
         return $special_price;
      }
      if (($sale->fields["sale_manufacturer"] == 0) || (($sale->fields["sale_manufacturer"] > 0) && ($product->fields["manufacturers_id"] == $sale->fields["sale_manufacturer"]))) {

This would be public_html/includes/functions/functions_prices.php

[mc12345678]

What is your setting for
If a product is a Special?
And is there a special associated with the product?

[FueledByMatt]

Ignore Specials Price - Apply to Product Price and Replace Special

No special associated, I only use SaleMaker

[mc12345678]

Ignore Specials Price - Apply to Product Price and Replace Special

No special associated, I only use SaleMaker

Try either changing it to the last one or simply circling back through the salemaker. After doing each of these, I was able to get/show that the base product and attributes were both on sale. Before that saw the same issue described.

[FueledByMatt]

SWEET!

Yeah I didn't try that last option before....Now i know what to do from now on, lol...thank you!

[mc12345678]

SWEET!

Yeah I didn't try that last option before....Now i know what to do from now on, lol...thank you!

Glad it worked, I knew it should somehow and was also surprised when I tried a similar setup on a brand new install... FYI, I did not look through the code posted above to validate or identify any issues. I had found "a solution" that was independent of that modification; however, it may still help others. :)


Where in that file did that additional code need to go?