[Done v155] admin/customers.php sortOrderHeader construction....

[carlwhat]

i count 16 instances of using a sortOrderHeader in this script. they all make use of the following line of code (or similar based on what is being sorted).

i have two proposed solution to it; i can see the value in each solution....

my issue and why i believe this to be a bug, is lets say i'm searching for a customer, and then i want to sort those results, the sort clears the search.

// original
<a href="<?php echo zen_href_link(basename($PHP_SELF) . '?list_order=firstname', '', 'NONSSL'); ?>"> 

// proposed solution 1
<a href="<?php echo zen_href_link(basename($PHP_SELF), zen_get_all_get_params(array('list_order')) . 'list_order=firstname', 'NONSSL')

// proposed solution 2
<a href="<?php echo zen_href_link(basename($PHP_SELF), zen_get_all_get_params(array('list_order','page')) . 'list_order=firstname', 'NONSSL')

best.

[DrByte]

Working on including this in v155: https://github.com/zencart/zencart/pull/820