Payflow module for v139 won't run under php 7

[badarac]

The current downloadable Payflow module was written for 1.3.9. It's worked fine in more recent releases though. I installed this on 1.5.5 running with php 7 and it receives the following error

PHP Parse error:  syntax error, unexpected '[', expecting ',' or ';' in /home/eclyonsc/public_html/includes/modules/payment/payflow.php on line 1195

. I changed the php level on the hosting account to 5.6 and it no longer gets an error. Any chance there's an updated version?

[mc12345678]

The current downloadable Payflow module was written for 1.3.9. It's worked fine in more recent releases though. I installed this on 1.5.5 running with php 7 and it receives the following error

PHP Parse error:  syntax error, unexpected '[', expecting ',' or ';' in /home/eclyonsc/public_html/includes/modules/payment/payflow.php on line 1195

. I changed the php level on the hosting account to 5.6 and it no longer gets an error. Any chance there's an updated version?

More than likely the code contains a function as the same name as the class just above it. Typical action to bring the code to PHP 7.0 level of operation is to change the function's name to __construct. That has been something compatible with PHP 5 for some time now...

There could be other code that casts the result of a variable to become a variable ie: $$var where $var ="me" would previously create a variable $me. In PHP 7.0 this should become ${$var} to generate $me...

[badarac]

More than likely the code contains a function as the same name as the class just above it. Typical action to bring the code to PHP 7.0 level of operation is to change the function's name to __construct. That has been something compatible with PHP 5 for some time now...

There could be other code that casts the result of a variable to become a variable ie: $$var where $var ="me" would previously create a variable $me. In PHP 7.0 this should become ${$var} to generate $me...

Thanks, I'll have a look at that and see if it's an easy fix.

[DrByte]

Does this match your line 1195? If so, I'm struggling to see any PHP7 issue with that. Hmmm...

          if ($order_totals[$i]['code'] == 'ot_total')    $optionsST['AMT']         = round($order_totals[$i]['value'],2);

[badarac]

Does this match your line 1195? If so, I'm struggling to see any PHP7 issue with that. Hmmm...

          if ($order_totals[$i]['code'] == 'ot_total')    $optionsST['AMT']         = round($order_totals[$i]['value'],2);

The mod downloaded from https://www.zen-cart.com/downloads.php?do=file&id=212 contains the following around 1195

          // handle other order totals:
          global $$order_totals[$i]['code'];
          if ((substr($order_totals[$i]['text'], 0, 1) == '-') || (isset($$order_totals[$i]['code']->credit_class) && $$order_totals[$i]['code']->credit_class == true)) {
            // handle credits
            $creditsApplied += round($order_totals[$i]['value'], 2);
          } else {
            // treat all other OT's as if they're related to handling fees or other extra charges to be added/included
            $surcharges += $order_totals[$i]['value'];
          }

I've made the following changes and it seems to have solved the problem

          // handle other order totals:
          global ${$order_totals[$i]['code']};
          if ((substr($order_totals[$i]['text'], 0, 1) == '-') || (isset($$order_totals[$i]['code']->credit_class) && ${$order_totals[$i]['code']->credit_class} == true)) {
            // handle credits
            $creditsApplied += round($order_totals[$i]['value'], 2);
          } else {
            // treat all other OT's as if they're related to handling fees or other extra charges to be added/included
            $surcharges += $order_totals[$i]['value'];
          }

[DrByte]

There are a couple places to change on that line.
Here's what v155 does in the main paypal module:

          if ((substr($order_totals[$i]['text'], 0, 1) == '-') || (isset(${$order_totals[$i]['code']}->credit_class) && ${$order_totals[$i]['code']}->credit_class == true)) {

[badarac]

There are a couple places to change on that line.
Here's what v155 does in the main paypal module:

          if ((substr($order_totals[$i]['text'], 0, 1) == '-') || (isset(${$order_totals[$i]['code']}->credit_class) && ${$order_totals[$i]['code']}->credit_class == true)) {

OOPS! Missed one. Thanks Dr B

[mc12345678]

OOPS! Missed one. Thanks Dr B

So submitting your 2nd plugin to ZC? :)

[badarac]

So submitting your 2nd plugin to ZC? :)

Oh a wise guy huh?

You mean Dr B hasn't already done that? I suppose I could pack it up and send it in.

[mc12345678]

Oh a wise guy huh?

You mean Dr B hasn't already done that? I suppose I could pack it up and send it in.

Who me?!

He does a lot, but can't do everything.