Results 1 to 3 of 3
  1. #1
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,018
    Plugin Contributions
    29

    Default [Done v155] admin, customers.php span tags not closed

    <td class="dataTableHeadingContent" align="left" valign="top">
    <?php echo (($_GET['list_order']=='lastname' or $_GET['list_order']=='lastname-desc') ? '<span class="SortOrderHeader">' . TABLE_HEADING_LASTNAME . '</span>' : TABLE_HEADING_LASTNAME); ?><br>
    <a href="<?php echo zen_href_link(basename($PHP_SELF), zen_get_all_get_params(array('list_order','page')) . 'list_order=lastname', 'NONSSL'); ?>"><?php echo ($_GET['list_order']=='lastname' ? '<span class="SortOrderHeader">Asc</span>' : '<span class="SortOrderHeaderLink">Asc</b>'); ?></a>&nbsp;

    All these spans are closed with /b and not /span
    Steve
    github.com/torvista: Apsona (php7), BackupMySQL Admin/Auto, Product Listing Sorter, Redsys payment module, Spanish Language Pack and more...

  2. #2
    Join Date
    Jan 2004
    Posts
    65,286
    Blog Entries
    7
    Plugin Contributions
    227

    Default Re: admin, customers.php span tags not closed

    You're right.

    And it's been like that since at least v1.3.8 ...
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,018
    Plugin Contributions
    29

    Default Re: admin, customers.php span tags not closed

    Since I have a hack in place just before that I wondered why I had never reported it before...but someone else did:
    https://www.zen-cart.com/showthread....aderLink-spans
    Steve
    github.com/torvista: Apsona (php7), BackupMySQL Admin/Auto, Product Listing Sorter, Redsys payment module, Spanish Language Pack and more...

 

 

Similar Threads

  1. Replies: 34
    Last Post: 24 Mar 2016, 08:06 PM
  2. Replies: 3
    Last Post: 17 Feb 2016, 10:24 AM
  3. Community feedback invited for v155-beta [now closed]
    By DrByte in forum Zen Cart Release Announcements
    Replies: 1
    Last Post: 11 Feb 2016, 01:38 AM
  4. Replies: 1
    Last Post: 9 Feb 2016, 09:54 PM
  5. Replies: 0
    Last Post: 1 Dec 2013, 03:11 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR