[Done v155a] Admin order page shows yellow circle for comments, when there are none

[jwlamb]

Ever since I upgraded to 1.5.5, the order page in the admin shows the yellow comment circle on every single order, regardless if they actually wrote a comment or not. Any clue why this is happening?

[DrByte]

If there's any text in the comment field for the first order-status-history record for that order, it will flag up the comments icon. That includes if your payment module put payment-related information in there. (Usually payment-related comments end up in a 2nd comment, so as to not clash with this customers-comment flag.)

[jwlamb]

Thanks DrByte, but the comment section is empty. This is flagging on every order, and only since I upgraded to 1.5.5.

[DrByte]

Then I'd check:
a) what's in the comments field in every orders_status_history record for those orders.
b) has the zen_get_order_comments() function definition been changed in your admin functions files

... cuz that function looks up all the comments on the order, by order number, grabs the first one in sort order of being added to the db, and if the comments field is not blank, the yellow icon is displayed.

[jwlamb]

DrByte, I checked the comments in the database, pre-1.5.5 the empty comments are '', post-1.5.5 the comments are ' '

Would having the space in the comments make it so that the flag would show? This would make sense why there is nothing showing in the order itself since a space doesn't show in text format, but does show that a character is in fact in the box.

Where would I find the extra space so I can remove it?

Thank you!

[jwlamb]

Would having the space in the comments make it so that the flag would show? This would make sense why there is nothing showing in the order itself since a space doesn't show in text format, but does show that a character is in fact in the box.

That's exactly what it was. I ran an export, removed the extra space from each order that didn't have comments and imported the new database. The flags disappeared, so the flag is showing correctly, just trying to find where the extra space is in the php. It's in the paypal checkout, I did a test order using a gift certificate and the extra space wasn't there. I'll post results when I find them.

Thank you.

[DrByte]

Oh wow, talk about a needle in a haystack!

Fortunately it's only related to PayPal Express Checkout.

In v155 we added the ability for the store to record any notes the customer enters on the PayPal side ... and because there are two parts to that, we dropped a space in between to separate them for readability. Unfortunately that space survives even when the customer enters no comments.

The fix is simple ... in the paypalwpp.php module, line 1838 you have:

'order_comment'   => urldecode($response['NOTE']) . ' ' . urldecode($response['PAYMENTREQUEST_0_NOTETEXT']),

Change it to this:

'order_comment'   => (isset($response['NOTE']) || isset($response['PAYMENTREQUEST_0_NOTETEXT']) ? urldecode($response['NOTE']) . ' ' . urldecode($response['PAYMENTREQUEST_0_NOTETEXT']) : ''),

Another approach could be the following, but I prefer the above approach because the following one is cleaning up what's added, instead of not adding it in the first place:

'order_comment'   => trim(urldecode($response['NOTE']) . ' ' . urldecode($response['PAYMENTREQUEST_0_NOTETEXT'])),

[jwlamb]

Thanks DrByte, that worked. I received an order and doesn't show as comments. When my next order with comments comes through I'll let you know that it works for both.

Thanks again!

[jwlamb]

Thanks DrByte, that worked. I received an order and doesn't show as comments. When my next order with comments comes through I'll let you know that it works for both.

Thanks again!

Finally got an order with comments, it works. I was starting to get concerned.