Page 7 of 11 FirstFirst ... 56789 ... LastLast
Results 61 to 70 of 103
  1. #61
    Join Date
    Jun 2003
    Location
    Newcastle UK
    Posts
    2,881
    Blog Entries
    2
    Plugin Contributions
    2

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Quote Originally Posted by mmcculli View Post
    I have moved the line down and it seem to have worked. Taxes on Shipping are now showing up as they did before I upgraded to 1.5.5a. So this very small change looks to have fixed the issue.

    So what are the side-effects of this change?
    Hi

    Currently hoping there aren't any. I updated our functional test suite recently, just to test this. The changes did not break any of the tests relating to tax calculations.

  2. #62
    Join Date
    Mar 2009
    Posts
    15
    Plugin Contributions
    0

    Default Re: Shipping tax not added in order confirmation - possible bug??

    I am not really sure of your internal process with bugs. I assume you need to run the change through some regression test units. So do I wait for an official patch or will you just reply to this thread if it looks ok for me to move live.

  3. #63
    Join Date
    Jan 2004
    Posts
    66,333
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: Shipping tax not added in order confirmation - possible bug??

    At this point our internal tests are showing no obvious ill side effects.

    If it were my site I'd go live with it now ... and keep a careful eye on order traffic and any errors in the /logs/ folder, etc.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  4. #64
    Join Date
    Oct 2005
    Location
    Finland
    Posts
    186
    Plugin Contributions
    1

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Maybe this could/should be added to the "Known Bugs (and fixes) with v1.5.5" tread, so people know why the have tax issues?

  5. #65
    Join Date
    Jan 2004
    Posts
    66,333
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Quote Originally Posted by rued View Post
    Maybe this could/should be added to the "Known Bugs (and fixes) with v1.5.5" tread, so people know why the have tax issues?
    Are you saying you've been encountering this same issue yourself?
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  6. #66
    Join Date
    Oct 2005
    Location
    Finland
    Posts
    186
    Plugin Contributions
    1

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Several people have, including me on several sites, yes.
    Have disabled most countries and turned of zone restrictions for now in a few sites, but most are pending updating because of this bug.

  7. #67
    Join Date
    Jan 2004
    Posts
    66,333
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Quote Originally Posted by rued View Post
    Several people have, including me on several sites, yes.
    Have disabled most countries and turned of zone restrictions for now in a few sites, but most are pending updating because of this bug.
    I wish I could reproduce it. Particularly because I want to understand why it wasn't an issue in v154, especially since the code in the proposed fix didn't change between versions.

    Beyond reproducing it I'd be even more interested in knowing exactly what's caused the change between versions.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  8. #68
    Join Date
    Oct 2005
    Location
    Finland
    Posts
    186
    Plugin Contributions
    1

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Oh, I'll make you a test site then, after my holiday - or on a rainy day. :)

  9. #69
    Join Date
    Mar 2010
    Location
    Nottingham UK
    Posts
    87
    Plugin Contributions
    1

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Hi all,

    I can confirm the same issue happened to me upgrading from v1.5.1 to v1.5.5a. I thought I had corrupted something, but then found this post. I turned off the zone on the shipping module as suggested by Ajeh and it started to work as expected. So I've just implemented Dr Byte's suggested code change and all working again with a zone specified in the shipping module. I'll update you all if there are any logs or side effects appearing.

    Thanks!

  10. #70
    Join Date
    Mar 2010
    Location
    Nottingham UK
    Posts
    87
    Plugin Contributions
    1

    Default Re: Shipping tax not added in order confirmation - possible bug??

    Hi all,

    As an update to the fix DrByte mentioned. It works fine for my worldpay payment, however when a customer pays 'on account' using the invoice mod from the add ons the shipping is once again calculated without tax on the shipping. I can rectify the issue by removing the zone from the shipping module again.

    Is anyone else able to re-produce this error?

    It is worth noting that the invoice mod is only officially compatible with v1.5.1, however I can't see where in its code it would effect the shipping tax? And if it happens with this payment add on, how many others may be affected?


    If anyone else could offer any ideas, they'll be much appreciated.

    Thanks all!

 

 
Page 7 of 11 FirstFirst ... 56789 ... LastLast

Similar Threads

  1. Can not get tax to be added to order total
    By harleyhar in forum General Questions
    Replies: 1
    Last Post: 28 Jul 2011, 12:10 AM
  2. Tax not being added to shipping
    By hamid84 in forum Currencies & Sales Taxes, VAT, GST, etc.
    Replies: 4
    Last Post: 13 Nov 2010, 11:22 PM
  3. Sales tax not being added to order
    By danilyn22 in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 29 Oct 2009, 07:12 PM
  4. bug in Canada Post shipping module? - no tax added
    By ptalindstrom in forum Addon Shipping Modules
    Replies: 4
    Last Post: 14 Jan 2008, 10:31 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR