[Done 155b] Shipping tax not added in order confirmation - possible bug??

[mmcculli]

Not sure how it all works but I just realized as I am using 4 Table Rate shipping modules I have four clones of includes/modules/shipping/table.php But my table2.php, table3.php and table4.php are not version 1.5.5. Old versions.

Of course right now when I am testing I am just using the first one table.php. Not the other three.

[Ajeh]

No, I can reproduce the problem ... now the goal is we are looking how to correct the problem ...

I was having issues with reproducing the problem as I did not have the Zone set on the shipping module and just had set the Tax Class ...

[mmcculli]

Just checking back in to see if you have been able to recreate the issue(bug) on your side so you can hopefully soon patch the bug.

[Ajeh]

Have recreated it and it happens when a Zone is set on the shipping module ... without the Zone set it works ...

We are still working on a solution for this ...

[frank18]

Have recreated it and it happens when a Zone is set on the shipping module ... without the Zone set it works ...

We are still working on a solution for this ...

So it wasn't just a botched up FTP upload on my end after all ??

[Ajeh]

My guess is you had a Zone set then did not when you reinstalled ...

It is possible that there was another issue, but so far I am not finding any other trigger for this. I thought your reinstall was the fix also, as the same thing happened for me. But then I realized that I had the Zone set when it was broken and on the new install I did not have the Zone set.

So it was just a dilussion on my testing, making me think a new install fixed it, until I really tested it a lot further for the real issue ...

[frank18]

My guess is you had a Zone set then did not when you reinstalled ...

It is possible that there was another issue, but so far I am not finding any other trigger for this. I thought your reinstall was the fix also, as the same thing happened for me. But then I realized that I had the Zone set when it was broken and on the new install I did not have the Zone set.

So it was just a dilussion on my testing, making me think a new install fixed it, until I really tested it a lot further for the real issue ...

Thanks for the update Ajeh. If I hate any error, bug, fault, whatever then it is one of an intermittent, inconsistent nature, just like one in the electrics in a car......

[mmcculli]

Is there anything I can do to help? I do have the website in a sandbox so can test things out if you like.

[DrByte]

As an EXPERIMENT (no guarantees here with this idea), you could try the following...

/includes/modules/checkout_process.php
Around line 51 you'll see this section of code:

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

Try moving the shipping-module part down a few lines, like this:

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

$shipping_modules = new shipping($_SESSION['shipping']);

Note: ZC v155b includes this fix:
https://github.com/zencart/zencart/pull/1034

[mmcculli]

I have moved the line down and it seem to have worked. Taxes on Shipping are now showing up as they did before I upgraded to 1.5.5a. So this very small change looks to have fixed the issue.

So what are the side-effects of this change?