How do I customize handling weights for this module?

[mc12345678]

Still reviewing the major code element, but for clarification, yes the constant > the value is the same as the value < constant, but note the difference in code to be performed following the two examples RodG provided. In his second version, the method is turned on (regardless of any previous off signal) if the shipping weight (yes still to be addressed) is greater than the constant but turned off or remains off if the shipping weight is less that the constant.

Again, all a matter of perspective and desire.

Now back to the code review.

[gruntre69]

Each time I have tried to make this work by adding the database value, I have uninstalled and re-installed the module. I have the constant showing in the admin settings for the module but the module fails to disable when the shipping weight reaches the threshold set. It does work with the money limit value and disable when the threshold is reached. This is what makes me wonder what the problem is a problem with the code finding the shipping weight.

[mc12345678]

In the function in the above code:

    function platinum() {
      global $order, $db;

Suggest the following modifications:

    function __construct() {
      global $order, $db, $shipping_weight;

I used bold to identify the two changes of making the shipping module PHP 7.0 compliant as well as adding the $shipping_weight value to the constructor. I did *not* modify your use of < or > in the comparison, as that issue still seems to be open.

[RodG]

I have a feeling that the shipping weight ($shipping_weight) is not available at that line of the code

Its a shipping module, its going to have the shipping weight available:)

Try adding a line
global $shipping_weight ;
Near the start of the file/function.

Also, please check other shipping modules to ensure that ive got the variable name correct (im working from memory here, and not even checking if my code examples are correct or not)...

Sorry, I cant comment on any of the code you supplied this time around, im using a mobile phone at the moment... screen is too small).

Please follow whatever advice mc1-8 provides (you are in good hands there). He is one of those that i expected would step in as soon as I responded to this thread. :)

Cheers
RodG

[RodG]

In the function in the above code:
Suggest the following modifications:

    function __construct() {
      global $order, $db, $shipping_weight;

I used bold to identify the two changes of making the shipping module PHP 7.0 compliant as well as adding the $shipping_weight value to the constructor

Excellent suggestions (stated mainly for the benefit of the OP). Personally I wouldn't have thought about this future proofing while providing the almost certain fix. And you did it without making my head spin for a change <grin>

G'night
RodG

[gruntre69]

In the function in the above code:

    function platinum() {
      global $order, $db;

Suggest the following modifications:

    function __construct() {
      global $order, $db, $shipping_weight;

I used bold to identify the two changes of making the shipping module PHP 7.0 compliant as well as adding the $shipping_weight value to the constructor. I did *not* modify your use of < or > in the comparison, as that issue still seems to be open.

Thank you very much. This has fixed it and it now works! All I need to do now is clone the modules. I really appreciate your help!

[mc12345678]

Its a shipping module, its going to have the shipping weight available:)

Try adding a line
global $shipping_weight ;
Near the start of the file/function.

Also, please check other shipping modules to ensure that ive got the variable name correct (im working from memory here, and not even checking if my code examples are correct or not)...

Sorry, I cant comment on any of the code you supplied this time around, im using a mobile phone at the moment... screen is too small).

Please follow whatever advice mc1-8 provides (you are in good hands there). He is one of those that i expected would step in as soon as I responded to this thread. :)

Cheers
RodG

I actually had this one in my "queue" to which to return. Wasn't too sure at the time to which "part" to reply. General weight issue or the dimensional part. :) one far easier than the other. :)

Although testing hadn't been performed the code when followed did show a difference. Just took a little more than reading the if part of the statement. (personally I had originally overlooked the two sets of code just expecting them to be in some way different. :) and wasn't until they were "called out" that I looked further.)

Yeah, it's unfortunate that most of the work to make relatively functional "basic" code operational with PHP 7.0 is all in renaming the class constructor. There are some that do more advanced ops or were constructed to be somewhat generic that still require a little effort, but that's not frequent.

Sadly when I was learning PHP a few years ago, I had begun with that constructor, but then seeing how other ZC apps were written (new and old), I "conformed". I am back on track now.