[Done v160] admin coupons pagination and selecting a coupon

[balihr]

This was reported to me several times before, but I never paid much attention to it...

On Discount Coupons admin page, I have 59 active coupons (displayed 20 per page) and 7 inactive coupons.



Some coupons are OK, but SOME simply reset and take me to the next page, with NO coupon selected.
Inspect element shows the following link: xxxxxx/coupon_admin.php?page=1&cid=29
When I click on that row, it just takes me to another coupons page, with no coupon selected on the right. URL is correct.



The one thing that confuses me most is that it doesn't happen with all coupons on Page 1, there are a few that work. If I change the number of coupons per page to a higher value and get all coupons on one page, it's all good.

I made a simple change in admin/coupon_admin.php on line 996:

if (($_GET['page'] == '' or $_GET['page'] == '1') and $_GET['cid'] != '') {

changed to

if ($_GET['page'] == '' and $_GET['cid'] != '') {

and the problems were gone, everything worked fine.

My questions:
1) is this really a fix or will it cause different problems?
2) comment above that line says "reset page when page is unknown" - why do we reset it if it's page 1 (URL parameter is page=1)?

Thanks!

[DrByte]

Should be harmless.

I'm mindful that v1.6.0 has removed that segment of the code. I haven't investigated whether simply removing that whole block might be okay in v155 as well.