[Done v155b]checkout_shipping: No method chosen after cart goes from virtual to mixed

[lat9]

Using a 1.5.5a installation with the demo products, add the "Single Download" product (id=179) to the cart. Login and go to checkout.

Since the order currently contains only a virtual product, the shipping method is set to free_free and the checkout_shipping page is properly bypassed and the order shows "Free Shipping".

Now, go back to the products' menu and add a 'physical' product to the cart and re-enter the checkout flow. The checkout_shipping page is displayed (with no message) and none of the shipping methods is selected. I'm pretty sure that previous version(s) of Zen Cart would display a message like "Your available shipping options have changed. Please re-select your desired shipping method.". The $_SESSION['shipping'] is still set to free_free.

[DrByte]

Is this unique to v155? Or did it happen in v154?

[lat9]

I just checked on a local zc1.5.4 test site: Same behavior.

[DrByte]

It seems the check is only done if the previously-selected shipping method is *not* free_free:

    if (!in_array($checkval, $checklist) && $_SESSION['shipping']['id'] != 'free_free') {
      $messageStack->add('checkout_shipping', ERROR_PLEASE_RESELECT_SHIPPING_METHOD, 'error');
    }

[DrByte]

It seems the check is only done if the previously-selected shipping method is *not* free_free:

    if (!in_array($checkval, $checklist) && $_SESSION['shipping']['id'] != 'free_free') {
      $messageStack->add('checkout_shipping', ERROR_PLEASE_RESELECT_SHIPPING_METHOD, 'error');
    }

In testing this with Ajeh, it appears as though this change should work, and in theory without any ill side-effects ...

Just remove the second test: ... && $_SESSION['shipping']['id'] != 'free_free'

Mind testing a bit to confirm it's not causing any undesired results?

[lat9]

Will do either later today or in the morning ...

[lat9]

Looks good, DrByte!

[DrByte]

https://github.com/zencart/zencart/pull/1316