One-Page Checkout [Support Thread]

[lat9]

The site was using FEC up until the recent upgrade to 1.5.7, so no idea if OPC would have the same issues on an older version of zen cart.
Yes, all bug fixes listed in that thread have been implemented.

To be clear, I have no issue with the form at all when OPC page first loads. But as soon as a shipping method selection is changed, the class is removed from the payment method fields, breaking their layout. I can only assume something in the OPC code is doing this as it doesn't expect that class to exist. They still perform their task, just don't look pretty.

OPC's AJAX handler (which comes into play when the shipping method is changed) loads the current template's version of the various tpl_modules_opc_*.php files.

Are there, perchance, some leftover FEC files that are coming into play?

[jeking]

I haven't seen a site running that version of PHP for a long time, nor have I done any integration testing with OPC on that very old version.

Fair enough. Seems like an odd error to be caused by PHP though. But we need to upgrade it anyway. Once that is done, we'll see were that leaves us.

[lat9]

Fair enough. Seems like an odd error to be caused by PHP though. But we need to upgrade it anyway. Once that is done, we'll see were that leaves us.

I agree about the oddness, but don't have enough information to provide any additional guidance.

[strelitzia]

OPC's AJAX handler (which comes into play when the shipping method is changed) loads the current template's version of the various tpl_modules_opc_*.php files.

Are there, perchance, some leftover FEC files that are coming into play?

Not that I'm aware of. I took a download of the FEC module and deleted any matching files that existed on the site.

Can you confirm that it's not expected and/or deliberate behaviour for the class names to be getting stripped of the form fields?

[lat9]

Not that I'm aware of. I took a download of the FEC module and deleted any matching files that existed on the site.

Can you confirm that it's not expected and/or deliberate behaviour for the class names to be getting stripped of the form fields?

Yes, I can confirm. OPC's AJAX processing uses the Zen Cart $template class to load the OPC sub-template modules to render its output.

Are there any debug-logs generated? How about browser's console-logs?

Update: Is the site publicly available for viewing? If so, send me a PM with the link.

[strelitzia]

I did some digging into this and found that the "form-control" class is not hard coded onto fields, but added via js when the page is initially loaded.

$('input[type="text"], input[type="password"], input[type="email"], input[type="tel"], textarea, input#state').addClass('form-control');
$('select').addClass('select_caret_icon form-control');

My guess is I have to re add these after OPC's AJAX handler has been fired. Any pointer in which file this needs to take place?

[strelitzia]

My guess is I have to re add these after OPC's AJAX handler has been fired. Any pointer in which file this needs to take place?

I added some code at line 495 of includes/modules/pages/jquery.checkout_one.js to replace the classes.

It's working correctly now.

[lat9]

I added some code at line 495 of includes/modules/pages/jquery.checkout_one.js to replace the classes.

It's working correctly now.

I'll point out that that's one of the more volatile modules in the OPC distribution (like it's up for another change in v2.3.5). Just remember to mark your changes appropriately so that they're not wiped out on an update!

[carlwhat]

Fair enough. Seems like an odd error to be caused by PHP though. But we need to upgrade it anyway. Once that is done, we'll see were that leaves us.

perhaps not that odd. from

https://www.php.net/manual/en/function.empty.php

Note:

Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error. In other words, the following will not work: empty(trim($name)). Instead, use trim($name) == false.

[lat9]

perhaps not that odd. from

https://www.php.net/manual/en/function.empty.php

Note:

Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error. In other words, the following will not work: empty(trim($name)). Instead, use trim($name) == false.

Nice one, @carlwhat! I'm guessing that that statement applies to constant definitions, too, since they're not variables.